From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, "Shawn O. Pearce" <spearce@spearce.org>
Subject: Re: [PATCH] receive-pack, fetch-pack: reject bogus pack that records objects twice
Date: Fri, 18 Nov 2011 16:08:25 -0500 [thread overview]
Message-ID: <20111118210825.GA14710@sigill.intra.peff.net> (raw)
In-Reply-To: <7v62ihkzhb.fsf@alter.siamese.dyndns.org>
On Fri, Nov 18, 2011 at 11:22:08AM -0800, Junio C Hamano wrote:
> >> > If we are fixing a thin pack (which should be the case most of the
> >> > time), we are rewriting the packfile anyway. Shouldn't we just omit
> >> > the duplicate?
> >> ...
> > ... But I guess there is some complexity
> > with deltified entries? As in, if the first entry is deltified but the
> > second is not, you would want to keep the second one?
>
> I think you answered your own question here; it is not "some complexity"
> but is exactly the "you need to memmove() in the output file" situation in
> the message you are responding to.
>
> Upon seeing a delta, you would not know if the same object as this delta
> represents appears later in the pack stream, which means until you read to
> the end you wouldn't know. You obviously would not want to hold onto all
> deltas in-core to "just omit the duplicate".
OK, that makes sense to me. It's nice to hear it confirmed from somebody
who obviously thought more about it.
-Peff
next prev parent reply other threads:[~2011-11-18 21:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-17 6:04 [PATCH] receive-pack, fetch-pack: reject bogus pack that records objects twice Junio C Hamano
2011-11-17 20:51 ` Shawn Pearce
2011-11-18 10:33 ` Jeff King
2011-11-18 18:41 ` Junio C Hamano
2011-11-18 18:44 ` Jeff King
2011-11-18 19:22 ` Junio C Hamano
2011-11-18 21:08 ` Jeff King [this message]
2011-11-18 23:50 ` Shawn Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111118210825.GA14710@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).