From: Thomas Rast <trast@student.ethz.ch>
To: Shahid Alam <shahid.alam@gmail.com>
Cc: <git@vger.kernel.org>, <gitster@pobox.com>,
Eric Wong <normalperson@yhbt.net>
Subject: Re: [PATCH] make git-svn resilient to log.abbrevcommit = true
Date: Thu, 24 Nov 2011 14:11:05 +0100 [thread overview]
Message-ID: <201111241411.05655.trast@student.ethz.ch> (raw)
In-Reply-To: <3A78B8F7-803C-4278-8B5F-4A1B02C9FF04@gmail.com>
[add Eric to Cc]
Shahid Alam wrote:
> Add --no-abbrev-commit arg to working_head_Info()'s invocation
> of git log.
[...]
> @@ -1803,7 +1803,7 @@ sub cmt_sha2rev_batch {
> sub working_head_info {
> my ($head, $refs) = @_;
> my @args = qw/log --no-color --no-decorate --first-parent
> - --pretty=medium/;
> + --no-abbrev-commit --pretty=medium/;
Undeniably a bug, but to prevent the same from happening again,
wouldn't it be better to rewrite it using simply
rev-list --first-parent --pretty=medium
?
--
Thomas Rast
trast@{inf,student}.ethz.ch
next prev parent reply other threads:[~2011-11-24 13:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-24 7:16 [PATCH] make git-svn resilient to log.abbrevcommit = true Shahid Alam
2011-11-24 13:11 ` Thomas Rast [this message]
2011-11-24 18:32 ` Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201111241411.05655.trast@student.ethz.ch \
--to=trast@student.ethz.ch \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=normalperson@yhbt.net \
--cc=shahid.alam@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).