* [PATCH] make git-svn resilient to log.abbrevcommit = true
@ 2011-11-24 7:16 Shahid Alam
2011-11-24 13:11 ` Thomas Rast
0 siblings, 1 reply; 3+ messages in thread
From: Shahid Alam @ 2011-11-24 7:16 UTC (permalink / raw)
To: git, gitster
Add --no-abbrev-commit arg to working_head_Info()'s invocation
of git log.
---
git-svn.perl | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/git-svn.perl b/git-svn.perl
index 351e743..da4c240 100755
--- a/git-svn.perl
+++ b/git-svn.perl
@@ -1803,7 +1803,7 @@ sub cmt_sha2rev_batch {
sub working_head_info {
my ($head, $refs) = @_;
my @args = qw/log --no-color --no-decorate --first-parent
- --pretty=medium/;
+ --no-abbrev-commit --pretty=medium/;
my ($fh, $ctx) = command_output_pipe(@args, $head);
my $hash;
my %max;
--
1.7.7.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] make git-svn resilient to log.abbrevcommit = true
2011-11-24 7:16 [PATCH] make git-svn resilient to log.abbrevcommit = true Shahid Alam
@ 2011-11-24 13:11 ` Thomas Rast
2011-11-24 18:32 ` Eric Wong
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Rast @ 2011-11-24 13:11 UTC (permalink / raw)
To: Shahid Alam; +Cc: git, gitster, Eric Wong
[add Eric to Cc]
Shahid Alam wrote:
> Add --no-abbrev-commit arg to working_head_Info()'s invocation
> of git log.
[...]
> @@ -1803,7 +1803,7 @@ sub cmt_sha2rev_batch {
> sub working_head_info {
> my ($head, $refs) = @_;
> my @args = qw/log --no-color --no-decorate --first-parent
> - --pretty=medium/;
> + --no-abbrev-commit --pretty=medium/;
Undeniably a bug, but to prevent the same from happening again,
wouldn't it be better to rewrite it using simply
rev-list --first-parent --pretty=medium
?
--
Thomas Rast
trast@{inf,student}.ethz.ch
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] make git-svn resilient to log.abbrevcommit = true
2011-11-24 13:11 ` Thomas Rast
@ 2011-11-24 18:32 ` Eric Wong
0 siblings, 0 replies; 3+ messages in thread
From: Eric Wong @ 2011-11-24 18:32 UTC (permalink / raw)
To: Thomas Rast; +Cc: Shahid Alam, git, gitster
Thomas Rast <trast@student.ethz.ch> wrote:
> Shahid Alam wrote:
> > Add --no-abbrev-commit arg to working_head_Info()'s invocation
> > of git log.
> [...]
> > @@ -1803,7 +1803,7 @@ sub cmt_sha2rev_batch {
> > sub working_head_info {
> > my ($head, $refs) = @_;
> > my @args = qw/log --no-color --no-decorate --first-parent
> > - --pretty=medium/;
> > + --no-abbrev-commit --pretty=medium/;
>
> Undeniably a bug, but to prevent the same from happening again,
> wouldn't it be better to rewrite it using simply
>
> rev-list --first-parent --pretty=medium
Yes, I've never been happy with using "git log" for any internals since
it's a porcelain. I'll gladly accept a tested patch which uses rev-list
instead. Thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-11-24 18:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-24 7:16 [PATCH] make git-svn resilient to log.abbrevcommit = true Shahid Alam
2011-11-24 13:11 ` Thomas Rast
2011-11-24 18:32 ` Eric Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).