From: Jeff King <peff@peff.net>
To: Nicolas Dudebout <nicolas.dudebout@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: Uniform branch coloring
Date: Wed, 30 Nov 2011 01:55:40 -0500 [thread overview]
Message-ID: <20111130065540.GD5317@sigill.intra.peff.net> (raw)
In-Reply-To: <CA+TMmK=476h1YyVcegWia2F+1bhOQyNLf-150qF1bnU8Wu3qJA@mail.gmail.com>
On Thu, Nov 17, 2011 at 02:08:38PM -0500, Nicolas Dudebout wrote:
> I was looking at the coloring of git branches in the output of
> different commands and had an idea.
> It seems to me that the color coding for branches should be uniform throughout.
That sounds like a reasonable goal. At the very least all of the spots
should be configurable, so you can make it uniform if you want to.
And then having unset config fallback to a "master" switch (e.g., if
color.branch.current is unset, use color.default.branch or whatever).
Which I think is close to what you write below.
> I have identified ways to address some of these problems:
> [...]
These all looked like reasonable goals to me. You will have to do a
little refactoring, I'm sure.
> What are your thoughts on that?
Go for it. Your ideas sound sane. You might hit some ugly complexities
in the implementation, but you won't know until you dig in and try. And
patches are much easier to review (and apply!) than ideas. :)
-Peff
prev parent reply other threads:[~2011-11-30 6:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-17 19:08 Uniform branch coloring Nicolas Dudebout
2011-11-30 6:55 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111130065540.GD5317@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=nicolas.dudebout@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).