From: Thomas Rast <trast@student.ethz.ch>
To: Sverre Rabbelier <srabbelier@gmail.com>
Cc: "Junio C Hamano" <gitster@pobox.com>,
"Jonathan Nieder" <jrnieder@gmail.com>,
"Jeff King" <peff@peff.net>, "Git List" <git@vger.kernel.org>,
"Daniel Barkalow" <barkalow@iabervon.org>,
"Ramkumar Ramachandra" <artagnon@gmail.com>,
"Dmitry Ivankov" <divanorama@gmail.com>,
"Johannes Schindelin" <Johannes.Schindelin@gmx.de>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Eric Herman" <eric@freesa.org>,
"Fernando Vezzosi" <buccia@repnz.net>
Subject: Re: [PATCH 3/3] fast-export: output reset command for commandline revs
Date: Wed, 30 Nov 2011 17:56:32 +0100 [thread overview]
Message-ID: <201111301756.32305.trast@student.ethz.ch> (raw)
In-Reply-To: <1320535407-4933-4-git-send-email-srabbelier@gmail.com>
Sverre Rabbelier wrote:
> When a revision is specified on the commandline we explicitly output
> a 'reset' command for it if it was not handled already. This allows
> for example the remote-helper protocol to use fast-export to create
> branches that point to a commit that has already been exported.
>
> Initial-patch-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
> Signed-off-by: Sverre Rabbelier <srabbelier@gmail.com>
My apologies if this is redundant, I'm not up to speed on progress
here. But a crash in t9350.19 caught my eye:
checking known breakage:
(
cd limit-by-paths &&
git fast-export master~2..master~1 > output &&
test_cmp output expected
)
==23766== Invalid read of size 1
==23766== at 0x4FD21E: prefixcmp (strbuf.c:9)
==23766== by 0x42B936: handle_tags_and_duplicates (fast-export.c:563)
==23766== by 0x42C274: cmd_fast_export (fast-export.c:732)
==23766== by 0x4051F1: run_builtin (git.c:308)
==23766== by 0x40538B: handle_internal_command (git.c:466)
==23766== by 0x4054A5: run_argv (git.c:512)
==23766== by 0x40562C: main (git.c:585)
==23766== Address 0x0 is not stack'd, malloc'd or (recently) free'd
==23766==
{
<insert_a_suppression_name_here>
Memcheck:Addr1
fun:prefixcmp
fun:handle_tags_and_duplicates
fun:cmd_fast_export
fun:run_builtin
fun:handle_internal_command
fun:run_argv
fun:main
}
==23766==
==23766== Process terminating with default action of signal 11 (SIGSEGV)
==23766== Access not within mapped region at address 0x0
==23766== at 0x4FD21E: prefixcmp (strbuf.c:9)
==23766== by 0x42B936: handle_tags_and_duplicates (fast-export.c:563)
==23766== by 0x42C274: cmd_fast_export (fast-export.c:732)
==23766== by 0x4051F1: run_builtin (git.c:308)
==23766== by 0x40538B: handle_internal_command (git.c:466)
==23766== by 0x4054A5: run_argv (git.c:512)
==23766== by 0x40562C: main (git.c:585)
The crash is hidden by the fact that the test is test_expect_failure.
It bisects to this commit. Perhaps we should distinguish between
test_expect_failure and test_expect_crash?...
--
Thomas Rast
trast@{inf,student}.ethz.ch
next prev parent reply other threads:[~2011-11-30 16:56 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-05 23:23 [PATCH 0/3] fast-export fixes Sverre Rabbelier
2011-11-05 23:23 ` [PATCH 1/3] t9350: point out that refs are not updated correctly Sverre Rabbelier
2011-11-06 4:31 ` Jonathan Nieder
2011-11-06 19:38 ` Sverre Rabbelier
2011-11-07 9:32 ` Jonathan Nieder
2012-10-24 17:52 ` Felipe Contreras
2012-10-24 18:08 ` Jonathan Nieder
2012-10-24 19:09 ` Felipe Contreras
2012-10-24 19:11 ` Jonathan Nieder
2012-10-25 4:19 ` Felipe Contreras
2012-10-25 4:27 ` Jonathan Nieder
2012-10-25 5:18 ` Felipe Contreras
2012-10-25 5:28 ` Jonathan Nieder
2012-10-25 5:39 ` Sverre Rabbelier
2012-10-25 5:50 ` Felipe Contreras
2012-10-25 6:07 ` Sverre Rabbelier
2012-10-25 6:19 ` Felipe Contreras
2012-10-25 7:06 ` Sverre Rabbelier
2012-10-25 7:34 ` Jonathan Nieder
2012-10-25 7:43 ` Sverre Rabbelier
2012-10-25 7:48 ` Jonathan Nieder
2012-10-25 7:50 ` Sverre Rabbelier
2012-10-25 13:33 ` Felipe Contreras
2012-10-25 5:40 ` Felipe Contreras
2012-10-25 5:53 ` Jonathan Nieder
2012-10-25 6:39 ` Felipe Contreras
2012-10-25 7:18 ` Jonathan Nieder
2012-10-25 16:43 ` Felipe Contreras
2012-10-24 21:41 ` Johannes Schindelin
2012-10-25 5:13 ` Felipe Contreras
2011-11-05 23:23 ` [PATCH 2/3] fast-export: do not refer to non-existing marks Sverre Rabbelier
2011-11-06 4:45 ` Jonathan Nieder
2011-11-06 19:40 ` Sverre Rabbelier
2019-01-29 19:41 ` Johannes Schindelin
2011-11-05 23:23 ` [PATCH 3/3] fast-export: output reset command for commandline revs Sverre Rabbelier
2011-11-06 5:01 ` Jonathan Nieder
2011-11-06 19:48 ` Sverre Rabbelier
2011-11-07 8:58 ` Jonathan Nieder
2011-11-07 5:52 ` Junio C Hamano
2011-11-07 5:53 ` Junio C Hamano
2011-11-30 16:56 ` Thomas Rast [this message]
2012-10-24 18:02 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201111301756.32305.trast@student.ethz.ch \
--to=trast@student.ethz.ch \
--cc=Johannes.Schindelin@gmx.de \
--cc=artagnon@gmail.com \
--cc=avarab@gmail.com \
--cc=barkalow@iabervon.org \
--cc=buccia@repnz.net \
--cc=divanorama@gmail.com \
--cc=eric@freesa.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=peff@peff.net \
--cc=srabbelier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).