* [PATCH] compat/getpass.c: Fix a sparse "symbol not declared" warning
@ 2011-11-30 20:54 Ramsay Jones
2011-12-01 18:19 ` Jeff King
0 siblings, 1 reply; 2+ messages in thread
From: Ramsay Jones @ 2011-11-30 20:54 UTC (permalink / raw)
To: Jeff King; +Cc: Junio C Hamano, GIT Mailing-list
In particular, sparse complains as follows:
SP compat/getpass.c
compat/getpass.c:5:6: warning: symbol 'getpass_echo' was not \
declared. Should it be static?
In order to suppress the warning, we include the getpass.h header
file which contains an appropriate extern declaration.
Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
---
Hi Jeff,
When you next re-roll your most recent credentials/getpass series, could
you please squash this patch in. (This patch was against pu @ 1cc922af,
but I guess you need to apply a similar patch to commit 8eca119c "stub out
getpass_echo function", 27-11-2011 instead)
Thanks!
ATB,
Ramsay Jones
compat/getpass.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/compat/getpass.c b/compat/getpass.c
index b5bd1dd..a145d27 100644
--- a/compat/getpass.c
+++ b/compat/getpass.c
@@ -1,4 +1,5 @@
#include "../git-compat-util.h"
+#include "getpass.h"
#ifdef HAVE_DEV_TTY
--
1.7.7
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] compat/getpass.c: Fix a sparse "symbol not declared" warning
2011-11-30 20:54 [PATCH] compat/getpass.c: Fix a sparse "symbol not declared" warning Ramsay Jones
@ 2011-12-01 18:19 ` Jeff King
0 siblings, 0 replies; 2+ messages in thread
From: Jeff King @ 2011-12-01 18:19 UTC (permalink / raw)
To: Ramsay Jones; +Cc: Junio C Hamano, GIT Mailing-list
On Wed, Nov 30, 2011 at 08:54:27PM +0000, Ramsay Jones wrote:
> When you next re-roll your most recent credentials/getpass series, could
> you please squash this patch in. (This patch was against pu @ 1cc922af,
> but I guess you need to apply a similar patch to commit 8eca119c "stub out
> getpass_echo function", 27-11-2011 instead)
Sure, makes sense. Thanks.
-Peff
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-12-01 18:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-30 20:54 [PATCH] compat/getpass.c: Fix a sparse "symbol not declared" warning Ramsay Jones
2011-12-01 18:19 ` Jeff King
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).