From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Linus Torvalds" <torvalds@linux-foundation.org>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Git Mailing List" <git@vger.kernel.org>
Subject: Re: git auto-repack is broken...
Date: Fri, 2 Dec 2011 13:13:59 -0500 [thread overview]
Message-ID: <20111202181358.GD24093@sigill.intra.peff.net> (raw)
In-Reply-To: <7vd3c6onhs.fsf@alter.siamese.dyndns.org>
On Fri, Dec 02, 2011 at 10:08:15AM -0800, Junio C Hamano wrote:
> Jeff King <peff@peff.net> writes:
>
> > But we shouldn't be packing totally unreferenced objects.
>
> Everything you said is correct in today's Git and I obviously know it, but
> I was taking the "Or have an extra option to..." at the end of the OP's
> message in the thread into account, so...
Ah, sorry, I missed the subtlety of Linus's "repacking the objects
results in problems..." from his later message and thought he just meant
repacking in general. Yes, it's a bad idea to repack unreachable objects
because then you could never prune anything.
I think just shrinking the --expire window that we already use is a much
more reasonable bet. It's not about preventing the loss of old work
(reflogs are there for that), but about avoiding hurting an actively
running, about-to-reference-the-objects git process. And 2 weeks is
quite conservative for that.
-Peff
next prev parent reply other threads:[~2011-12-02 18:14 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-02 16:22 git auto-repack is broken Linus Torvalds
2011-12-02 16:27 ` Ævar Arnfjörð Bjarmason
2011-12-02 16:56 ` Linus Torvalds
2011-12-02 17:10 ` Jeff King
2011-12-02 17:35 ` Junio C Hamano
2011-12-02 17:45 ` Jeff King
2011-12-02 18:08 ` Junio C Hamano
2011-12-02 18:13 ` Jeff King [this message]
2011-12-03 19:42 ` Brandon Casey
2011-12-07 22:12 ` Nicolas Pitre
2011-12-07 22:53 ` Jeff King
2011-12-08 0:18 ` Nicolas Pitre
2011-12-08 0:45 ` Jeff King
2011-12-08 3:35 ` Nicolas Pitre
2011-12-08 3:40 ` Jeff King
2011-12-09 17:35 ` Junio C Hamano
2011-12-09 18:34 ` Nicolas Pitre
2011-12-08 0:49 ` Jeff King
-- strict thread matches above, loose matches on Subject: below --
2011-12-03 6:55 George Spelvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111202181358.GD24093@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).