* [PATCH] Add MYMETA.yml to perl/.gitignore
@ 2011-12-01 20:31 Sebastian Morr
2011-12-01 22:35 ` Jeff King
0 siblings, 1 reply; 5+ messages in thread
From: Sebastian Morr @ 2011-12-01 20:31 UTC (permalink / raw)
To: git
This file is auto-generated in the process of building the Perl
extension.
Signed-off-by: Sebastian Morr <sebastian@morr.cc>
---
Good day, fine Sirs and Madams,
I just built Git for the first time, issued "git status", and there
was this untracked file. I guess you could call that an itch. This patch
fixes that, however, I'm not sure whether this is a relevant issue.
Didn't know whom to Cc, as the perl directory doesn't seem to get much
attention lately.
Kind regards,
Sebastian
perl/.gitignore | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/perl/.gitignore b/perl/.gitignore
index 98b2477..9235e73 100644
--- a/perl/.gitignore
+++ b/perl/.gitignore
@@ -1,5 +1,6 @@
perl.mak
perl.mak.old
+MYMETA.yml
blib
blibdirs
pm_to_blib
--
1.7.8.rc4.dirty
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] Add MYMETA.yml to perl/.gitignore
2011-12-01 20:31 [PATCH] Add MYMETA.yml to perl/.gitignore Sebastian Morr
@ 2011-12-01 22:35 ` Jeff King
2011-12-02 22:55 ` [PATCH v2] " Sebastian Morr
0 siblings, 1 reply; 5+ messages in thread
From: Jeff King @ 2011-12-01 22:35 UTC (permalink / raw)
To: Sebastian Morr; +Cc: git
On Thu, Dec 01, 2011 at 09:31:15PM +0100, Sebastian Morr wrote:
> This file is auto-generated in the process of building the Perl
> extension.
>
> [...]
>
> I just built Git for the first time, issued "git status", and there
> was this untracked file. I guess you could call that an itch. This patch
> fixes that, however, I'm not sure whether this is a relevant issue.
Thanks, I wrote the same patch myself last week. I could swear I sent it
to the list, but it appears that I forgot.
The only thing I would add is the reason this is suddenly coming up now:
generating MYMETA.yml is done only by new-ish versions of
ExtUtils::MakeMaker (it started for me with perl 5.14, which just hit
debian unstable recently). The file just contains extra information
about the environment and arguments to the Makefile-building process,
and can be safely deleted.
-Peff
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] Add MYMETA.yml to perl/.gitignore
2011-12-01 22:35 ` Jeff King
@ 2011-12-02 22:55 ` Sebastian Morr
2011-12-02 23:41 ` Junio C Hamano
0 siblings, 1 reply; 5+ messages in thread
From: Sebastian Morr @ 2011-12-02 22:55 UTC (permalink / raw)
To: gitster; +Cc: Jeff King, git
This file is auto-generated by newer versions of ExtUtils::MakeMaker
(presumably starting with the version shipping with Perl 5.14). It just
contains extra information about the environment and arguments to the
Makefile-building process, and can be safely deleted.
Signed-off-by: Sebastian Morr <sebastian@morr.cc>
---
perl/.gitignore | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/perl/.gitignore b/perl/.gitignore
index 98b2477..9235e73 100644
--- a/perl/.gitignore
+++ b/perl/.gitignore
@@ -1,5 +1,6 @@
perl.mak
perl.mak.old
+MYMETA.yml
blib
blibdirs
pm_to_blib
--
1.7.8.rc4.dirty
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2] Add MYMETA.yml to perl/.gitignore
2011-12-02 22:55 ` [PATCH v2] " Sebastian Morr
@ 2011-12-02 23:41 ` Junio C Hamano
2011-12-03 0:07 ` Sebastian Morr
0 siblings, 1 reply; 5+ messages in thread
From: Junio C Hamano @ 2011-12-02 23:41 UTC (permalink / raw)
To: Sebastian Morr; +Cc: Jeff King, git
Sebastian Morr <sebastian@morr.cc> writes:
> This file is auto-generated by newer versions of ExtUtils::MakeMaker
> (presumably starting with the version shipping with Perl 5.14). It just
> contains extra information about the environment and arguments to the
> Makefile-building process, and can be safely deleted.
"safely deleted" sounds as if you made "make clean" remove it. I do not
mind doing s/and can be.*/and should be ignored./ myself, if you want.
Does running "make clean" actually remove it, by the way?
> Signed-off-by: Sebastian Morr <sebastian@morr.cc>
> ---
> perl/.gitignore | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/perl/.gitignore b/perl/.gitignore
> index 98b2477..9235e73 100644
> --- a/perl/.gitignore
> +++ b/perl/.gitignore
> @@ -1,5 +1,6 @@
> perl.mak
> perl.mak.old
> +MYMETA.yml
> blib
> blibdirs
> pm_to_blib
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] Add MYMETA.yml to perl/.gitignore
2011-12-02 23:41 ` Junio C Hamano
@ 2011-12-03 0:07 ` Sebastian Morr
0 siblings, 0 replies; 5+ messages in thread
From: Sebastian Morr @ 2011-12-03 0:07 UTC (permalink / raw)
To: Junio C Hamano; +Cc: Jeff King, git
On Fri, Dec 02, 2011 at 03:41:24PM -0800, Junio C Hamano wrote:
> Sebastian Morr <sebastian@morr.cc> writes:
>
> > This file is auto-generated by newer versions of ExtUtils::MakeMaker
> > (presumably starting with the version shipping with Perl 5.14). It just
> > contains extra information about the environment and arguments to the
> > Makefile-building process, and can be safely deleted.
>
> "safely deleted" sounds as if you made "make clean" remove it. I do not
> mind doing s/and can be.*/and should be ignored./ myself, if you want.
You're very welcome to do that.
> Does running "make clean" actually remove it, by the way?
Yes, it does. perl/perl.mak (which, in turn, is generated by MakeMaker
via perl/Makefile) takes care of that file explicitly.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-12-03 0:07 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-12-01 20:31 [PATCH] Add MYMETA.yml to perl/.gitignore Sebastian Morr
2011-12-01 22:35 ` Jeff King
2011-12-02 22:55 ` [PATCH v2] " Sebastian Morr
2011-12-02 23:41 ` Junio C Hamano
2011-12-03 0:07 ` Sebastian Morr
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).