From: Jeff King <peff@peff.net>
To: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH, v4] git-tag: introduce --cleanup option
Date: Mon, 5 Dec 2011 16:51:48 -0500 [thread overview]
Message-ID: <20111205215148.GA22663@sigill.intra.peff.net> (raw)
In-Reply-To: <1322972426-7591-1-git-send-email-kirill@shutemov.name>
On Sun, Dec 04, 2011 at 06:20:26AM +0200, Kirill A. Shutemov wrote:
> From: "Kirill A. Shutemov" <kirill@shutemov.name>
>
> Normally git tag stripes tag message lines starting with '#', trailing
> spaces from every line and empty lines from the beginning and end.
s/stripes/strips
> --cleanup allows to select different cleanup modes for tag message.
> It provides the same interface as --cleanup option in git-commit.
Thanks, I think this is better, though it would be better still if they
could share the code. As a minor nit, I think the patch would be a
little easier to read and review if you split the actual changes from
the refactoring to use the "struct create_tag_options".
More importantly, though, this seems to break t6300 badly. I haven't
looked into why yet, though.
-Peff
next prev parent reply other threads:[~2011-12-05 21:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-04 4:20 [PATCH, v4] git-tag: introduce --cleanup option Kirill A. Shutemov
2011-12-05 21:51 ` Jeff King [this message]
2011-12-05 22:30 ` Junio C Hamano
2011-12-05 22:41 ` Junio C Hamano
2011-12-07 2:58 ` Kirill A. Shutemov
2011-12-05 22:27 ` Jeff King
2011-12-05 22:29 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111205215148.GA22663@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=kirill@shutemov.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).