From: Jeff King <peff@peff.net>
To: git@vger.kernel.org
Subject: [PATCHv2 0/13] credential helpers
Date: Tue, 6 Dec 2011 01:21:28 -0500 [thread overview]
Message-ID: <20111206062127.GA29046@sigill.intra.peff.net> (raw)
This is a re-roll of the credential helper series. Changes are noted
below.
[01/13]: test-lib: add test_config_global variant
[02/13]: t5550: fix typo
[03/13]: introduce credentials API
- simplified "first word is alnum" rules. You can now use "!f() {"
to get a shell snippet helper.
- documentation clarifications based on discussion with Junio
- fix missing EOF in test script (same as the fixup in pu)
- minor code style fixups
[04/13]: credential: add function for parsing url components
[05/13]: http: use credential API to get passwords
[06/13]: credential: apply helper config
[07/13]: credential: add credential.*.username
[08/13]: credential: make relevance of http path configurable
[09/13]: docs: end-user documentation for the credential subsystem
[10/13]: credentials: add "cache" helper
- don't die on unknown action, as suggested by credential helper
docs. This is to leave room for new actions later.
[11/13]: strbuf: add strbuf_add*_urlencode
[12/13]: credentials: add "store" helper
- don't die on unknown action, as above
- "store --store=foo" is now spelled "store --file=foo"
- passwords are now stored in most-recently-added order
- drop remove/lookup restrictions, per discussion with Junio
This last one has an interesting side effect. You can now
do: "git credential-store erase </dev/null" to erase everything
(since you have provided no restrictions, it matches everything).
It's not something git would send intentionally, but it seems
accidentally destructive (e.g., for some reason the main git process
dies and closes the pipe). Perhaps a "credential on the wire" should
be re-defined as a set of key/value lines followed by a blank line
to signal "end"?
[13/13]: t: add test harness for external credential helpers
- actually invoke cleanup functions. The lib-credential script
provides a best-effort cleanup function, since external helpers
may be writing to system storage outsid of the trash directory.
But in v1 we didn't actually call it.
-Peff
next reply other threads:[~2011-12-06 6:21 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-06 6:21 Jeff King [this message]
2011-12-06 6:22 ` [PATCHv2 01/13] test-lib: add test_config_global variant Jeff King
2011-12-06 6:22 ` [PATCHv2 02/13] t5550: fix typo Jeff King
2011-12-06 6:22 ` [PATCHv2 03/13] introduce credentials API Jeff King
2011-12-06 6:22 ` [PATCHv2 04/13] credential: add function for parsing url components Jeff King
2011-12-06 6:22 ` [PATCHv2 05/13] http: use credential API to get passwords Jeff King
2011-12-06 6:22 ` [PATCHv2 06/13] credential: apply helper config Jeff King
2011-12-06 23:58 ` Junio C Hamano
2011-12-07 0:45 ` Jeff King
2011-12-07 0:49 ` Jeff King
2011-12-06 6:22 ` [PATCHv2 07/13] credential: add credential.*.username Jeff King
2011-12-06 6:22 ` [PATCHv2 08/13] credential: make relevance of http path configurable Jeff King
2011-12-06 6:22 ` [PATCHv2 09/13] docs: end-user documentation for the credential subsystem Jeff King
2011-12-06 6:22 ` [PATCHv2 10/13] credentials: add "cache" helper Jeff King
2011-12-06 6:23 ` [PATCHv2 11/13] strbuf: add strbuf_add*_urlencode Jeff King
2011-12-06 6:23 ` [PATCHv2 12/13] credentials: add "store" helper Jeff King
2011-12-06 21:50 ` Junio C Hamano
2011-12-09 23:19 ` Jeff King
2011-12-06 6:23 ` [PATCHv2 13/13] t: add test harness for external credential helpers Jeff King
2011-12-06 21:51 ` Junio C Hamano
2011-12-06 22:08 ` Jeff King
2011-12-06 21:40 ` [PATCHv2 0/13] " Junio C Hamano
2011-12-07 6:42 ` Jeff King
2011-12-08 21:34 ` Junio C Hamano
2011-12-09 2:29 ` Jeff King
2011-12-09 18:00 ` Junio C Hamano
2011-12-09 23:18 ` Jeff King
2011-12-09 23:34 ` Junio C Hamano
2011-12-09 23:39 ` Jeff King
2011-12-09 23:56 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111206062127.GA29046@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).