git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: git@vger.kernel.org
Subject: [PATCHv2 01/13] test-lib: add test_config_global variant
Date: Tue, 6 Dec 2011 01:22:28 -0500	[thread overview]
Message-ID: <20111206062228.GA29233@sigill.intra.peff.net> (raw)
In-Reply-To: <20111206062127.GA29046@sigill.intra.peff.net>

The point of test_config is to simultaneously set a config
variable and register its cleanup handler, like:

  test_config core.foo bar

However, it stupidly assumes that $1 contained the name of
the variable, which means it won't work for:

  test_config --global core.foo bar

We could try to parse the command-line ourselves and figure
out which parts need to be fed to test_unconfig. But since
this is likely the most common variant, it's much simpler
and less error-prone to simply add a new function.

Signed-off-by: Jeff King <peff@peff.net>
---
 t/test-lib.sh |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/t/test-lib.sh b/t/test-lib.sh
index bdd9513..160479b 100644
--- a/t/test-lib.sh
+++ b/t/test-lib.sh
@@ -379,6 +379,11 @@ test_config () {
 	git config "$@"
 }
 
+test_config_global () {
+	test_when_finished "test_unconfig --global '$1'" &&
+	git config --global "$@"
+}
+
 # Use test_set_prereq to tell that a particular prerequisite is available.
 # The prerequisite can later be checked for in two ways:
 #
-- 
1.7.8.rc4.4.g884ec

  reply	other threads:[~2011-12-06  6:22 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-06  6:21 [PATCHv2 0/13] credential helpers Jeff King
2011-12-06  6:22 ` Jeff King [this message]
2011-12-06  6:22 ` [PATCHv2 02/13] t5550: fix typo Jeff King
2011-12-06  6:22 ` [PATCHv2 03/13] introduce credentials API Jeff King
2011-12-06  6:22 ` [PATCHv2 04/13] credential: add function for parsing url components Jeff King
2011-12-06  6:22 ` [PATCHv2 05/13] http: use credential API to get passwords Jeff King
2011-12-06  6:22 ` [PATCHv2 06/13] credential: apply helper config Jeff King
2011-12-06 23:58   ` Junio C Hamano
2011-12-07  0:45     ` Jeff King
2011-12-07  0:49       ` Jeff King
2011-12-06  6:22 ` [PATCHv2 07/13] credential: add credential.*.username Jeff King
2011-12-06  6:22 ` [PATCHv2 08/13] credential: make relevance of http path configurable Jeff King
2011-12-06  6:22 ` [PATCHv2 09/13] docs: end-user documentation for the credential subsystem Jeff King
2011-12-06  6:22 ` [PATCHv2 10/13] credentials: add "cache" helper Jeff King
2011-12-06  6:23 ` [PATCHv2 11/13] strbuf: add strbuf_add*_urlencode Jeff King
2011-12-06  6:23 ` [PATCHv2 12/13] credentials: add "store" helper Jeff King
2011-12-06 21:50   ` Junio C Hamano
2011-12-09 23:19   ` Jeff King
2011-12-06  6:23 ` [PATCHv2 13/13] t: add test harness for external credential helpers Jeff King
2011-12-06 21:51   ` Junio C Hamano
2011-12-06 22:08     ` Jeff King
2011-12-06 21:40 ` [PATCHv2 0/13] " Junio C Hamano
2011-12-07  6:42   ` Jeff King
2011-12-08 21:34     ` Junio C Hamano
2011-12-09  2:29       ` Jeff King
2011-12-09 18:00         ` Junio C Hamano
2011-12-09 23:18           ` Jeff King
2011-12-09 23:34             ` Junio C Hamano
2011-12-09 23:39               ` Jeff King
2011-12-09 23:56                 ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111206062228.GA29233@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).