From: Jeff King <peff@peff.net>
To: Thomas Rast <trast@student.ethz.ch>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] userdiff: allow * between cpp funcname words
Date: Tue, 6 Dec 2011 14:02:17 -0500 [thread overview]
Message-ID: <20111206190217.GD9492@sigill.intra.peff.net> (raw)
In-Reply-To: <a639d328e15bce3057de9238ee31097d15850de1.1323189110.git.trast@student.ethz.ch>
On Tue, Dec 06, 2011 at 05:35:08PM +0100, Thomas Rast wrote:
> The cpp pattern, used for C and C++, would not match the start of a
> declaration such as
>
> static char *prepare_index(int argc,
>
> because it did not allow for * anywhere between the various words that
> constitute the modifiers, type and function name. Fix it.
>
> Signed-off-by: Thomas Rast <trast@student.ethz.ch>
> ---
>
> This is a really sneaky one-character bug that I cannot believe went
> unnoticed for so long, seeing as there are plenty of instances within
> git itself where it matters.
Looks reasonable to me. You can see the difference, for instance, with:
git show -U1 3c73a1d
(The -U1 is because of the annoying "we will start looking for the
header at the top of context, not the top of changes" behavior I
mentioned last week).
-Peff
next prev parent reply other threads:[~2011-12-06 19:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-06 16:35 [PATCH] userdiff: allow * between cpp funcname words Thomas Rast
2011-12-06 19:02 ` Jeff King [this message]
2011-12-06 20:17 ` Thomas Rast
2011-12-06 20:19 ` Jeff King
2011-12-06 20:52 ` Johannes Sixt
2011-12-06 21:07 ` René Scharfe
2011-12-06 21:15 ` Junio C Hamano
2011-12-07 8:04 ` Thomas Rast
2011-12-07 21:13 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111206190217.GD9492@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).