From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jeff King <peff@peff.net>, git@vger.kernel.org
Subject: Re: [PATCH, v4] git-tag: introduce --cleanup option
Date: Wed, 7 Dec 2011 04:58:46 +0200 [thread overview]
Message-ID: <20111207025837.GA31369@shutemov.name> (raw)
In-Reply-To: <7vvcpuk5ex.fsf@alter.siamese.dyndns.org>
On Mon, Dec 05, 2011 at 02:41:26PM -0800, Junio C Hamano wrote:
> Jeff King <peff@peff.net> writes:
>
> > More importantly, though, this seems to break t6300 badly. I haven't
> > looked into why yet, though.
>
> Probably two issues.
>
> - opt.message (and the original 'message') was misnamed and confused the
> patch author what "if (!message && !buf->len)" meant.
>
> - "opt" is a structure meant to be extensible, but is not initialized as
> a whole, inviting future errors.
Sorry for that and thanks for the investigation.
> It still seems to be broken with respect to the primary thing the patch
> wanted to do (t7400 "git tag -F commentsfile comments-annotated-tag" does
> not seem to produce an expected result), so I'll kick it back to the
> Kirill to look at.
CLEANUP_ALL should always be default regardless of opt.message_given.
I'll send new version.
--
Kirill A. Shutemov
next prev parent reply other threads:[~2011-12-07 2:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-04 4:20 [PATCH, v4] git-tag: introduce --cleanup option Kirill A. Shutemov
2011-12-05 21:51 ` Jeff King
2011-12-05 22:30 ` Junio C Hamano
2011-12-05 22:41 ` Junio C Hamano
2011-12-07 2:58 ` Kirill A. Shutemov [this message]
2011-12-05 22:27 ` Jeff King
2011-12-05 22:29 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111207025837.GA31369@shutemov.name \
--to=kirill@shutemov.name \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).