git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Koch <thomas@koch.ro>
To: Joseph Huttner <huttnified@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: How to make devs write better commit messages
Date: Wed, 7 Dec 2011 08:06:09 +0100	[thread overview]
Message-ID: <201112070806.09539.thomas@koch.ro> (raw)
In-Reply-To: <CAOJsP-X0ZWT5HLHcBc2FmhoMpWFOvEFADiM9jGZ9R1ctqHDJ9w@mail.gmail.com>

Joseph Huttner:
> The bottom line is that good commit messages are really important, so
> we should make it as easy as possible for developers to go ahead and
> write a perfect commit message every time they commit code.

I recently started to work with the code review system Gerrit[1]. First I did 
not pay attention to it, but later I was amazed that the commit message can 
(and should) be reviewed just like the code changes.

So if you're using a code review prozess (you should!) then also include the 
commit message in the review.

[1] http://en.wikipedia.org/wiki/Gerrit_%28software%29

Thomas Koch, http://www.koch.ro

      parent reply	other threads:[~2011-12-07  7:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-06 22:55 How to make devs write better commit messages Joseph Huttner
2011-12-06 23:18 ` Michael Schubert
2011-12-07  2:28   ` Junio C Hamano
2011-12-07  0:08 ` Hilco Wijbenga
2011-12-07  7:06 ` Thomas Koch [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201112070806.09539.thomas@koch.ro \
    --to=thomas@koch.ro \
    --cc=git@vger.kernel.org \
    --cc=huttnified@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).