From: Jeff King <peff@peff.net>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, Vijay Lakshminarayanan <laksvij@gmail.com>,
Viresh Kumar <viresh.kumar@st.com>,
Shiraz HASHIM <shiraz.hashim@st.com>
Subject: Re: [PATCH 1/4] test: add missing "&&" after echo command
Date: Wed, 7 Dec 2011 18:11:40 -0500 [thread overview]
Message-ID: <20111207231140.GE21852@sigill.intra.peff.net> (raw)
In-Reply-To: <20111207231002.GD21852@sigill.intra.peff.net>
On Wed, Dec 07, 2011 at 06:10:03PM -0500, Jeff King wrote:
> On Wed, Dec 07, 2011 at 08:45:40AM -0600, Jonathan Nieder wrote:
>
> > diff --git a/t/t7501-commit.sh b/t/t7501-commit.sh
> > index 3ad04363..da75abc1 100755
> > --- a/t/t7501-commit.sh
> > +++ b/t/t7501-commit.sh
> > @@ -60,7 +60,7 @@ test_expect_success \
> >
> > test_expect_success \
> > "next commit" \
> > - "echo 'bongo bongo bongo' >file \
> > + "echo 'bongo bongo bongo' >file && \
> > git commit -m next -a"
>
> Patch is obviously correct, but isn't the "\" here just superfluous and
> error-prone? Maybe it should just be dropped from the new version (and
> possibly from other tests in t7501).
Oh, nevermind. I just read your patch 3, which does that and much more.
I approve.
-Peff
next prev parent reply other threads:[~2011-12-07 23:11 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-06 8:23 Query on git commit amend Viresh Kumar
2011-12-06 9:01 ` Konstantin Khomoutov
2011-12-06 19:09 ` Dirk Süsserott
2011-12-06 9:11 ` Johannes Sixt
2011-12-06 9:20 ` Viresh Kumar
2011-12-06 9:22 ` Viresh Kumar
2011-12-06 15:46 ` Vijay Lakshminarayanan
2011-12-06 19:11 ` Jeff King
2011-12-07 2:18 ` Vijay Lakshminarayanan
2011-12-06 20:03 ` Junio C Hamano
2011-12-06 21:00 ` Junio C Hamano
2011-12-07 14:42 ` [PATCH/RFC 0/4] Re: commit: honor --no-edit Jonathan Nieder
2011-12-07 14:45 ` [PATCH 1/4] test: add missing "&&" after echo command Jonathan Nieder
2011-12-07 23:10 ` Jeff King
2011-12-07 23:11 ` Jeff King [this message]
2011-12-07 14:49 ` [PATCH 2/4] test: remove a porcelain test that hard-codes commit names Jonathan Nieder
2011-12-07 14:50 ` [PATCH 3/4] t7501 (commit): modernize style Jonathan Nieder
2011-12-07 14:54 ` [PATCH 4/4] test: commit --amend should honor --no-edit Jonathan Nieder
2011-12-07 2:28 ` Query on git commit amend Vijay Lakshminarayanan
2011-12-07 4:20 ` Viresh Kumar
2011-12-07 4:53 ` Björn Steinbrink
2011-12-07 5:45 ` Viresh Kumar
2011-12-07 15:06 ` Vijay Lakshminarayanan
2011-12-08 17:52 ` Junio C Hamano
2011-12-09 4:49 ` Viresh Kumar
2011-12-08 5:26 ` Viresh Kumar
2011-12-08 5:30 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111207231140.GE21852@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=laksvij@gmail.com \
--cc=shiraz.hashim@st.com \
--cc=viresh.kumar@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).