From: Jeff King <peff@peff.net>
To: Sebastian Schuberth <sschuberth@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
Stefan Naewe <stefan.naewe@gmail.com>,
Eric <eric.advincula@gmail.com>,
git@vger.kernel.org, msysgit@googlegroups.com
Subject: Re: [PATCH 1/2] t5540: test DAV push with authentication
Date: Tue, 13 Dec 2011 18:16:30 -0500 [thread overview]
Message-ID: <20111213231630.GB12432@sigill.intra.peff.net> (raw)
In-Reply-To: <CAHGBnuO1CFGacMQb+Md_uGsLu=V9bGDpcFLd9Lb4C5jSN+uUiw@mail.gmail.com>
On Tue, Dec 13, 2011 at 10:28:07PM +0100, Sebastian Schuberth wrote:
> On Tue, Dec 13, 2011 at 21:17, Jeff King <peff@peff.net> wrote:
>
> > We don't currently test this case at all, and instead just
> > test the DAV mechanism over an unauthenticated push. That
> > isn't very realistic, as most people will want to
> > authenticate pushes.
>
> Thanks for adding this, Peff!
You're welcome. Thank you for forwarding the bug report. I would never
have seen it on the msysgit list, and for some reason it seems that
msysgit people are more likely to use DAV.
Having looked a lot at the http code the past month or two, I knew it
was pretty flaky and I was nervous when we added Stefan's patch (and no,
I don't blame Stefan; his patch was completely reasonable, but just
happened to trigger a problem in a seldom-looked-at corner of the code).
But I hadn't looked at http-push at all until yesterday, and it didn't
even occur to me that there was another whole area of code relying in a
very obscure way on the http.c auth code. I'll take a look at some of
the refactoring I've done in http.c (both for the credentials topic as
well as the bundle topic) and see if we can't integrate http-push.c a
little more smoothly.
-Peff
prev parent reply other threads:[~2011-12-13 23:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-13 20:17 [PATCH 1/2] t5540: test DAV push with authentication Jeff King
2011-12-13 20:25 ` [PATCH] Revert "http: don't always prompt for password" Jeff King
2011-12-13 21:09 ` Junio C Hamano
2011-12-13 21:22 ` Eric Advincula
2011-12-13 23:18 ` Jeff King
2011-12-13 23:19 ` Jeff King
2011-12-13 23:20 ` Jeff King
2011-12-14 0:11 ` Jeff King
2011-12-14 0:33 ` Junio C Hamano
2011-12-14 8:20 ` Matthieu Moy
2011-12-13 21:25 ` Junio C Hamano
2011-12-13 23:10 ` Jeff King
2011-12-13 21:28 ` [PATCH 1/2] t5540: test DAV push with authentication Sebastian Schuberth
2011-12-13 23:16 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111213231630.GB12432@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=eric.advincula@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=msysgit@googlegroups.com \
--cc=sschuberth@gmail.com \
--cc=stefan.naewe@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).