From: Jeff King <peff@peff.net>
To: nathan.panike@gmail.com
Cc: git@vger.kernel.org
Subject: Re: [BUG] in rev-parse
Date: Wed, 14 Dec 2011 16:01:57 -0500 [thread overview]
Message-ID: <20111214210157.GA8990@sigill.intra.peff.net> (raw)
In-Reply-To: <20111214184926.GB18335@llunet.cs.wisc.edu>
On Wed, Dec 14, 2011 at 12:49:27PM -0600, nathan.panike@gmail.com wrote:
> In my local git.git:
>
> $ git rev-parse 73c6b3575bc638b7096ec913bd91193707e2265d^@
> 57526fde5df201a99afa6d122c3266b3a1c5673a
> 942e6baa92846e5628752c65a22bc4957d8de4d0
>
> $ git rev-parse --short 73c6b3575bc638b7096ec913bd91193707e2265d^@
> 57526fd
> 942e6ba
> fatal: Needed a single revision
>
> ^^^ I don't believe this "fatal" message should be here
It looks like "--short" implies "--verify", and you cannot "--verify"
multiple sha1s.
But the documentation for "--short" says only:
--short::
--short=number::
Instead of outputting the full SHA1 values of object names try to
abbreviate them to a shorter unique name. When no length is specified
7 is used. The minimum length is 4.
which would imply to me that not only should your example work, but this
should, too:
$ git rev-parse HEAD HEAD^
803b1a83b0ec5f04dfb770e83e11211e0015630f
28c2058b6048d32abc0a23b827ab0b26a0332b9b
$ git rev-parse --short HEAD HEAD^
fatal: Needed a single revision
On the other hand, it has been like this since it was introduced in
2006, and I wonder if scripts rely on the --verify side effect.
As a work-around, you can get what you want with:
git rev-list --no-walk --abbrev-commit $sha1^@
-Peff
next prev parent reply other threads:[~2011-12-14 21:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-14 18:49 [BUG] in rev-parse nathan.panike
2011-12-14 21:01 ` Jeff King [this message]
2011-12-15 3:20 ` Junio C Hamano
2011-12-15 7:05 ` Jeff King
2011-12-15 17:43 ` Junio C Hamano
2011-12-15 22:53 ` Michael Haggerty
2011-12-17 12:02 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111214210157.GA8990@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=nathan.panike@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).