From: Martin Fick <mfick@codeaurora.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: Git List <git@vger.kernel.org>
Subject: Re: git help prune accuracy?
Date: Thu, 15 Dec 2011 16:01:52 -0700 [thread overview]
Message-ID: <201112151601.52968.mfick@codeaurora.org> (raw)
In-Reply-To: <7v1us5mqc4.fsf@alter.siamese.dyndns.org>
On Thursday, December 15, 2011 03:18:19 pm Junio C Hamano
wrote:
> Martin Fick <mfick@codeaurora.org> writes:
> >> objects from the object database. In addition, it
> >>
> >> prunes the unpacked objects that are also found in
> >> packs by running git prune-packed.
> >>
> >> The last sentence seems like it should maybe have the
> >> following fix:
> >>
> >> s/it prunes the unpacked/it prunes the unreferenced/
> >
> > Ack, I meant:
> >
> > s/it prunes the unpacked/it prunes the unreachable/
>
> "In addition" part is about objects that exist in loose
> format that are also found in packs and has nothing to
> do with reachability.
>
> Running "git pack-objects" to collect loose objects into
> a new pack will not remove these loose objects that are
> copied into that new pack. Because we try to access
> objects from an already open packfile before trying a
> loose object file, removing these now-redundant loose
> ones after they are packed makes sense. And that is what
> "git prune-packed" does.
Thanks Junio, that makes a lot of sense. I don't know why I
was not getting that from the description even though that
was exactly what I was looking for. Maybe it was because of
the intro/summary line? Now that I think I understand what
it is doing, it seems like this command is more about
"pruning loose objects" (whether unreachable or already
packed) than it is about "pruning unreachable objects"
(which could be loose or packed)? The summary line reads:
git-prune - Prune all unreachable objects from the object
database
Maybe I am not familiar enough with git terminology, but
does "object database" imply loose objects only? Because
the word "all" in that summary makes it sound like it will
prune all unreachable objects (loose and packed).
I don't quite have an alternative suggestion for a better
summary, the best I could do (but don't like) is:
git-prune - Prune loose objects (unreachable or packed)
-Martin
--
Employee of Qualcomm Innovation Center, Inc. which is a
member of Code Aurora Forum
next prev parent reply other threads:[~2011-12-15 23:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-15 21:32 git help prune accuracy? Martin Fick
2011-12-15 21:53 ` Martin Fick
2011-12-15 22:18 ` Junio C Hamano
2011-12-15 23:01 ` Martin Fick [this message]
2011-12-16 0:04 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201112151601.52968.mfick@codeaurora.org \
--to=mfick@codeaurora.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).