From: Pete Wyckoff <pw@padd.com>
To: Luke Diamand <luke@diamand.org>
Cc: Git List <git@vger.kernel.org>
Subject: Re: BUG: git-p4: can't add files with special chars
Date: Sat, 17 Dec 2011 08:27:54 -0500 [thread overview]
Message-ID: <20111217132754.GB31271@padd.com> (raw)
In-Reply-To: <4EE6688A.2030105@diamand.org>
luke@diamand.org wrote on Mon, 12 Dec 2011 20:48 +0000:
> I just noticed this today. You can't add a file from git to perforce
> that contains a p4 special character (@,#,% or *).
>
> There is code to cope going the other way round (p4 file with
> special character in it) but if you create a file in git and then
> try to git-p4 submit, it fails.
>
> I've just tried a quick and simple fix, and it turns out that it's
> not that easy as the special characters get expanded to %40, %2A and
> so-on. The % seems to get further expanded by python...
Entertaining. Probably p4_add() and friends should stop using
system. And add option "-f" when wildcards are detected. I
wouldn't be surprised if this turned into a larger set of issues.
-- Pete
prev parent reply other threads:[~2011-12-17 13:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-12 20:48 BUG: git-p4: can't add files with special chars Luke Diamand
2011-12-17 13:27 ` Pete Wyckoff [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111217132754.GB31271@padd.com \
--to=pw@padd.com \
--cc=git@vger.kernel.org \
--cc=luke@diamand.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).