From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, "Shawn O. Pearce" <spearce@spearce.org>
Subject: Re: [PATCH] remote-curl: don't pass back fake refs
Date: Mon, 19 Dec 2011 16:29:32 -0500 [thread overview]
Message-ID: <20111219212932.GA18743@sigill.intra.peff.net> (raw)
In-Reply-To: <7v39cgmety.fsf@alter.siamese.dyndns.org>
On Mon, Dec 19, 2011 at 01:28:09PM -0800, Junio C Hamano wrote:
> > Do you want to squash in those tests, or should I re-send with a commit
> > message more fully explaining the situation?
>
> I was lazy and added these three lines at the end:
>
> This also fixes pushing with --mirror to a smart-http remote that uses
> alternates. The fake ".have" refs the server gives to avoid unnecessary
> network transfer has a similar bad interactions with the machinery.
>
> but it may warrant a more thorough write-up there.
I think that's probably enough. I could restructure the whole text to
talk less about capabilities^{} and more about generically preventing
fake refs, but I really don't think there's much point.
-Peff
prev parent reply other threads:[~2011-12-19 21:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-17 10:45 [PATCH] remote-curl: don't pass back fake refs Jeff King
2011-12-19 17:10 ` Jeff King
2011-12-19 19:28 ` Junio C Hamano
2011-12-19 21:12 ` Jeff King
2011-12-19 21:28 ` Junio C Hamano
2011-12-19 21:29 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111219212932.GA18743@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).