git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nathan Panike <nwp@cs.wisc.edu>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: "Nathan W. Panike" <nathan.panike@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] Specify a precision for the length of a subject string
Date: Wed, 21 Dec 2011 08:53:53 -0600	[thread overview]
Message-ID: <20111221145352.GB13097@llunet.cs.wisc.edu> (raw)
In-Reply-To: <m2liq6go7y.fsf@igel.home>

On Wed, Dec 21, 2011 at 12:26:25PM +0100, Andreas Schwab wrote:
> "Nathan W. Panike" <nathan.panike@gmail.com> writes:
> 
> > $ git log --pretty='%h %30s' d165204 -1
> 
> In C's formatted output this syntax denotes a minimum field width, not a
> precision, so it will probably be surprising to many people.

C semantics are already broken because (from git-log(1))

"If you add a - (minus sign) after % of a placeholder, line-feeds that
immediately precede the expansion are deleted if and only if the placeholder
expands to an empty string."

rather than indicating justification of the field.
> 
> Andreas.
> 
> -- 
> Andreas Schwab, schwab@linux-m68k.org
> GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
> "And now for something completely different."

  reply	other threads:[~2011-12-21 14:54 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-20 22:07 [PATCH] Specify a precision for the length of a subject string Nathan W. Panike
2011-12-20 22:15 ` Thomas Rast
2011-12-20 22:50   ` Nathan Panike
2011-12-21  4:38 ` Jeff King
2011-12-21 14:51   ` Nathan Panike
2011-12-23 10:09     ` Jeff King
2011-12-23 10:35       ` Jeff King
2011-12-23 20:58         ` Junio C Hamano
2011-12-23 23:02           ` Jeff King
2011-12-23 23:03             ` Jeff King
2011-12-23 10:35       ` [PATCH 1/2] pretty: refactor --format "magic" placeholders Jeff King
2011-12-23 10:36       ` [PATCH 2/2] pretty: allow "max-size" magic for all placeholders Jeff King
2011-12-21 11:26 ` [PATCH] Specify a precision for the length of a subject string Andreas Schwab
2011-12-21 14:53   ` Nathan Panike [this message]
2011-12-23  9:41     ` Miles Bader

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111221145352.GB13097@llunet.cs.wisc.edu \
    --to=nwp@cs.wisc.edu \
    --cc=git@vger.kernel.org \
    --cc=nathan.panike@gmail.com \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).