From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: nathan.panike@gmail.com, git@vger.kernel.org
Subject: Re: [PATCH] Specify a precision for the length of a subject string
Date: Fri, 23 Dec 2011 18:02:28 -0500 [thread overview]
Message-ID: <20111223230228.GA1718@sigill.intra.peff.net> (raw)
In-Reply-To: <7v1urvc8fb.fsf@alter.siamese.dyndns.org>
On Fri, Dec 23, 2011 at 12:58:00PM -0800, Junio C Hamano wrote:
> > Here's how I would have done it. Not involving %w at all, but applying
> > equally to all placeholders.
>
> Hmm, just curious why you rejected the %w() approach, as enhancing %w
> sounded to me like a better approach at the design level, but that was a
> knee-jerk reaction without inspecting the codepaths involved myself hence
> not knowing the potential amount of work required.
Not so much rejecting as I took a quick look at how I would have done
what your original patch did, and it was simple enough that I took it
all the way to working and decided to post it. I left it up to you to
decide whether using %w would be more sensible. I just wanted to present
another alternative for discussion.
-Peff
next prev parent reply other threads:[~2011-12-23 23:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-20 22:07 [PATCH] Specify a precision for the length of a subject string Nathan W. Panike
2011-12-20 22:15 ` Thomas Rast
2011-12-20 22:50 ` Nathan Panike
2011-12-21 4:38 ` Jeff King
2011-12-21 14:51 ` Nathan Panike
2011-12-23 10:09 ` Jeff King
2011-12-23 10:35 ` Jeff King
2011-12-23 20:58 ` Junio C Hamano
2011-12-23 23:02 ` Jeff King [this message]
2011-12-23 23:03 ` Jeff King
2011-12-23 10:35 ` [PATCH 1/2] pretty: refactor --format "magic" placeholders Jeff King
2011-12-23 10:36 ` [PATCH 2/2] pretty: allow "max-size" magic for all placeholders Jeff King
2011-12-21 11:26 ` [PATCH] Specify a precision for the length of a subject string Andreas Schwab
2011-12-21 14:53 ` Nathan Panike
2011-12-23 9:41 ` Miles Bader
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111223230228.GA1718@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=nathan.panike@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).