From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Johannes Sixt <j6t@kdbg.org>, Joey Hess <joey@kitenet.net>,
git@vger.kernel.org
Subject: Re: [PATCH 1/3] expanded hook api with stdio support
Date: Tue, 3 Jan 2012 15:06:42 -0500 [thread overview]
Message-ID: <20120103200642.GH20926@sigill.intra.peff.net> (raw)
In-Reply-To: <7vsjjwtvf1.fsf@alter.siamese.dyndns.org>
On Tue, Jan 03, 2012 at 11:53:22AM -0800, Junio C Hamano wrote:
> Johannes Sixt <j6t@kdbg.org> writes:
>
> > IMO, as the first step, the user of this infrastructure should only be
> > required to construct the hook input as a strbuf, and receive the hook
> > output, if needed, also as a strbuf.
>
> Now you brought it up, I think I would agree. The only reason I suggested
> a callback feeder approach was because I somehow was hoping that it may be
> possible to share more code with the codepath for textconv that may not
> want to hold too much buffer in core when we know the data is only used
> sequencially and I wanted to see more things to go through streaming API
> in the future.
Even if we don't make the input streaming, it would be nice to factor
the concept of "feed input to program and read its output without
deadlocking" into something independent of hooks.
The credential helper code could potentially have the same deadlock.
Possibly also clean/smudge filters.
Maybe it could even be part of the run-command interface?
-Peff
next prev parent reply other threads:[~2012-01-03 20:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-30 1:07 extended hook api and tweak-fetch hook Joey Hess
2011-12-30 1:07 ` [PATCH 1/3] expanded hook api with stdio support Joey Hess
2011-12-30 9:47 ` Johannes Sixt
2011-12-30 17:13 ` Joey Hess
2011-12-30 18:04 ` Johannes Sixt
2012-01-03 19:53 ` Junio C Hamano
2012-01-03 20:06 ` Jeff King [this message]
2012-01-03 21:44 ` Junio C Hamano
2011-12-30 1:07 ` [PATCH 2/3] preparations for tweak-fetch hook Joey Hess
2011-12-30 1:07 ` [PATCH 3/3] add " Joey Hess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120103200642.GH20926@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
--cc=joey@kitenet.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).