From: Jeff King <peff@peff.net>
To: Jan Engelhardt <jengelh@medozas.de>
Cc: git@vger.kernel.org, trast@student.ethz.ch
Subject: Re: [PATCH] gitignore: warn about pointless syntax
Date: Mon, 9 Jan 2012 11:28:02 -0500 [thread overview]
Message-ID: <20120109162802.GA2374@sigill.intra.peff.net> (raw)
In-Reply-To: <1326123647-18352-2-git-send-email-jengelh@medozas.de>
On Mon, Jan 09, 2012 at 04:40:47PM +0100, Jan Engelhardt wrote:
> +static inline void check_bogus_wildcard(const char *file, const char *p)
> +{
> + if (strstr(p, "**") == NULL)
> + return;
> + warning(_("Pattern \"%s\" from file \"%s\": Double asterisk does not "
> + "have a special meaning and is interpreted just like a single "
> + "asterisk.\n"), file, p);
Wouldn't this also match the meaningful "foo\**"?
-Peff
next prev parent reply other threads:[~2012-01-09 16:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-09 15:40 gitignore warn about ** submission Jan Engelhardt
2012-01-09 15:40 ` [PATCH] gitignore: warn about pointless syntax Jan Engelhardt
2012-01-09 16:28 ` Jeff King [this message]
2012-01-09 19:43 ` Junio C Hamano
2012-01-09 22:33 ` Jeff King
2012-01-10 5:42 ` Jan Engelhardt
2012-01-10 6:01 ` Junio C Hamano
2012-01-10 7:01 ` Jan Engelhardt
2012-01-10 7:02 ` Jan Engelhardt
2012-01-10 9:44 ` Thomas Rast
2012-01-10 18:51 ` Jeff King
-- strict thread matches above, loose matches on Subject: below --
2012-01-09 11:34 [patch] " Jan Engelhardt
2012-01-09 13:44 ` Thomas Rast
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120109162802.GA2374@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=jengelh@medozas.de \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).