From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Nicolas Pitre <nico@fluxnic.net>
Subject: Re: thin packs ending up fat
Date: Thu, 12 Jan 2012 20:59:20 -0500 [thread overview]
Message-ID: <20120113015920.GB8245@sigill.intra.peff.net> (raw)
In-Reply-To: <20120113015117.GA8245@sigill.intra.peff.net>
On Thu, Jan 12, 2012 at 08:51:17PM -0500, Jeff King wrote:
> > Tweak the recomputation avoidance logic, so that we do not punt on
> > computing delta against a preferred base object.
> >
> > Signed-off-by: Junio C Hamano <gitster@pobox.com>
>
> Other than that, it looks good to me.
>
> Signed-off-by: Jeff King <peff@peff.net>
Actually, Nicolas asked for the numbers to go into the
commit message (and gave his acked-by). So maybe append:
The effect of this patch can be seen on two simulated
upload-pack workloads. The first is based on 44 reflog
entries from my git.git origin/master reflog, and represents
the packs that kernel.org produced to send me git updates
for the past month or two. The second workload represents
much larger fetches, going from git's v1.0.0 tag to v1.1.0,
then v1.1.0 to v1.2.0, and so on.
The table below shows the average generated pack size and
the average CPU time consumed for each dataset, both before
and after the patch:
dataset
| reflog | tags
---------------------------------
before | 53358 | 2750977
size after | 32398 | 2668479
change | -39% | -3%
---------------------------------
before | 0.18 | 1.12
CPU after | 0.18 | 1.15
change | +0% | +3%
This patch makes a much bigger difference for packs with a
shorter slice of history (since its effect is seen at the
boundaries of the pack) though it has some benefit even for
larger packs.
Acked-by: Nicolas Pitre <nico@fluxnic.net>
next prev parent reply other threads:[~2012-01-13 1:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-12 22:15 thin packs ending up fat Jeff King
2012-01-12 22:32 ` Jeff King
2012-01-12 23:54 ` Nicolas Pitre
2012-01-13 0:14 ` Junio C Hamano
2012-01-13 1:31 ` Junio C Hamano
2012-01-13 1:51 ` Jeff King
2012-01-13 1:59 ` Jeff King [this message]
2012-01-13 7:19 ` Junio C Hamano
2012-01-13 15:15 ` Jeff King
2012-01-13 2:19 ` Nicolas Pitre
2012-01-13 8:28 ` Ævar Arnfjörð Bjarmason
2012-01-13 15:55 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120113015920.GB8245@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=nico@fluxnic.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).