[PATCH] docs: minor grammar fixes for v1.7.9 release notes

[PATCH] docs: minor grammar fixes for v1.7.9 release notes

[Jeff King]

Signed-off-by: Jeff King <peff@peff.net>
---
Easier to view with --color-words, of course.

I also looked through "git log --first-parent v1.7.8..master" to see if
anything had been missed. I think you hit the feature highlights pretty
well (I notice you mostly include features and not bug-fixes, which I
assume is to keep the list to a readable length).

 Documentation/RelNotes/1.7.9.txt |   13 +++++++------
 1 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/Documentation/RelNotes/1.7.9.txt b/Documentation/RelNotes/1.7.9.txt
index f1294b4..95320aa 100644
--- a/Documentation/RelNotes/1.7.9.txt
+++ b/Documentation/RelNotes/1.7.9.txt
@@ -12,19 +12,20 @@ Updates since v1.7.8
 
  * Git uses gettext to translate its most common interface messages
    into the user's language if translations are available and the
-   locale is appropriately set. Distributors can drop in new PO files
+   locale is appropriately set. Distributors can drop new PO files
    in po/ to add new translations.
 
- * The code to handle username/password for HTTP transaction used in
+ * The code to handle username/password for HTTP transactions used in
    "git push" & "git fetch" learned to talk "credential API" to
    external programs to cache or store them, to allow integration with
    platform native keychain mechanisms.
 
- * The prompted input in the terminal use our own getpass() replacement
-   when possible. HTTP transactions used to ask username without echoing
-   back what was typed, but with this change you will see it as you type.
+ * The input prompts in the terminal use our own getpass() replacement
+   when possible. HTTP transactions used to ask for the username without
+   echoing back what was typed, but with this change you will see it as
+   you type.
 
- * The internal of "revert/cherry-pick" has been tweaked to prepare
+ * The internals of "revert/cherry-pick" have been tweaked to prepare
    building more generic "sequencer" on top of the implementation that
    drives them.
 
-- 
1.7.9.rc2.293.gaae2

Re: [PATCH] docs: minor grammar fixes for v1.7.9 release notes

[Junio C Hamano]

Jeff King <peff@peff.net> writes:

> Signed-off-by: Jeff King <peff@peff.net>
> ---
> Easier to view with --color-words, of course.

Thanks ;-)

> ... (I notice you mostly include features and not bug-fixes, which I
> assume is to keep the list to a readable length).

Actually my intention regarding fixes are:

 - never mention follow-up fixes to new topics merged since v1.7.8 at all;

 - omit mentioning trivial fixes that not many people would be bitten by
   and actually be hurt in real life (i.e. typo in an error message); and

 - make sure as many fixes are covered in "Fixes since v1.7.8" section.

So "keep the list short" is only one-third of the motivation.

Re: [PATCH] docs: minor grammar fixes for v1.7.9 release notes

[Jeff King]

On Thu, Jan 26, 2012 at 11:15:08AM -0800, Junio C Hamano wrote:

> > ... (I notice you mostly include features and not bug-fixes, which I
> > assume is to keep the list to a readable length).
> 
> Actually my intention regarding fixes are:
> 
>  - never mention follow-up fixes to new topics merged since v1.7.8 at all;
> 
>  - omit mentioning trivial fixes that not many people would be bitten by
>    and actually be hurt in real life (i.e. typo in an error message); and
> 
>  - make sure as many fixes are covered in "Fixes since v1.7.8" section.
> 
> So "keep the list short" is only one-third of the motivation.

That makes sense.

I was specifically thinking of 02f7914 (remote-curl: don't pass back
fake refs), because "git push --mirror" failing is an often-reported bug
for github (and the solution is to upgrade your git client). But looking
again, I see that the fix was actually in v1.7.8.2, so it is included by
the "...and all of the fixes in the maintenance releases" text.

In general, it seems like most of our fixes go onto the maintenance
track, so the "fixes" section of a major release ends up being empty.
Which I think is a good thing.

-Peff