From: Jonathan Nieder <jrnieder@gmail.com>
To: Felipe Contreras <felipec@infradead.org>
Cc: git@vger.kernel.org,
"Felipe Contreras" <felipe.contreras@gmail.com>,
"Lee Marlow" <lee.marlow@gmail.com>,
"Shawn O. Pearce" <spearce@spearce.org>,
"SZEDER Gábor" <szeder@ira.uka.de>
Subject: Re: [PATCH v2 4/4] completion: be nicer with zsh
Date: Mon, 30 Jan 2012 11:53:24 -0600 [thread overview]
Message-ID: <20120130175324.GH10618@burratino> (raw)
In-Reply-To: <1327944197-6379-5-git-send-email-felipec@infradead.org>
Felipe Contreras wrote:
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -657,7 +657,8 @@ __git_merge_strategies=
> # is needed.
> __git_compute_merge_strategies ()
> {
> - : ${__git_merge_strategies:=$(__git_list_merge_strategies)}
> + test "$__git_merge_strategies" && return
> + __git_merge_strategies=$(__git_list_merge_strategies 2> /dev/null)
Why the new redirect? If I add debugging output to
__git_list_merge_strategies that writes to stderr, I want to see it.
Why the 'test "$foo"' form instead of [[ -n which is more common in
this completion script? Why use "return" instead of
[[ -n $var ]] || var=$(...)
which feels a little simpler?
next prev parent reply other threads:[~2012-01-30 17:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-30 17:23 [PATCH 0/4] completion: trivial cleanups Felipe Contreras
2012-01-30 17:23 ` [PATCH v2 2/4] completion: remove unused code Felipe Contreras
[not found] ` <1327944197-6379-2-git-send-email-felipec@infradead.org>
2012-01-30 17:34 ` [PATCH v2 1/4] completion: simplify __git_remotes Jonathan Nieder
2012-01-30 18:27 ` Junio C Hamano
[not found] ` <1327944197-6379-4-git-send-email-felipec@infradead.org>
2012-01-30 17:50 ` [PATCH v2 3/4] completion: cleanup __gitcomp* Jonathan Nieder
2012-01-30 19:03 ` Junio C Hamano
2012-01-30 21:25 ` Junio C Hamano
2012-01-31 0:15 ` SZEDER Gábor
2012-01-31 0:25 ` Jonathan Nieder
[not found] ` <1327944197-6379-5-git-send-email-felipec@infradead.org>
2012-01-30 17:53 ` Jonathan Nieder [this message]
2012-01-30 18:10 ` [PATCH v2 4/4] completion: be nicer with zsh Felipe Contreras
2012-01-30 18:25 ` Jonathan Nieder
2012-01-30 18:56 ` Felipe Contreras
2012-01-30 19:03 ` Jonathan Nieder
2012-01-30 19:09 ` Junio C Hamano
2012-01-30 19:22 ` Felipe Contreras
2012-01-30 19:28 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120130175324.GH10618@burratino \
--to=jrnieder@gmail.com \
--cc=felipe.contreras@gmail.com \
--cc=felipec@infradead.org \
--cc=git@vger.kernel.org \
--cc=lee.marlow@gmail.com \
--cc=spearce@spearce.org \
--cc=szeder@ira.uka.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).