From: Jonathan Nieder <jrnieder@gmail.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: "Junio C Hamano" <gitster@pobox.com>,
"Felipe Contreras" <felipec@infradead.org>,
git@vger.kernel.org, "Lee Marlow" <lee.marlow@gmail.com>,
"Shawn O. Pearce" <spearce@spearce.org>,
"SZEDER Gábor" <szeder@ira.uka.de>
Subject: Re: [PATCH v2 4/4] completion: be nicer with zsh
Date: Mon, 30 Jan 2012 13:28:34 -0600 [thread overview]
Message-ID: <20120130192834.GA28920@burratino> (raw)
In-Reply-To: <CAMP44s0dU5zQLnen_DSONOum7P1UsPTASSkF1sJE2m7kAwx21A@mail.gmail.com>
Felipe Contreras wrote:
> What would you rather use?
>
> [ "$__git_merge_strategies" ] &&
> __git_merge_strategies=$(__git_list_merge_strategies)
>
> That's 90 characters long. Although much better without the 2>/dev/null.
>
> if [ "$__git_merge_strategies" ]; then
> __git_merge_strategies=$(__git_list_merge_strategies)
> fi
Neither, since they both have the test inverted. But I prefer to
explicitly use the "-n" operator.
[[ -n $__git_merge_strategies ]] ||
__git_merge_strategies=$(__git_list_merge_strategies)
seems as fine as any other spelling to me. It means "either this
value has already been computed and cached, or we need to compute it".
prev parent reply other threads:[~2012-01-30 19:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-30 17:23 [PATCH 0/4] completion: trivial cleanups Felipe Contreras
2012-01-30 17:23 ` [PATCH v2 2/4] completion: remove unused code Felipe Contreras
[not found] ` <1327944197-6379-2-git-send-email-felipec@infradead.org>
2012-01-30 17:34 ` [PATCH v2 1/4] completion: simplify __git_remotes Jonathan Nieder
2012-01-30 18:27 ` Junio C Hamano
[not found] ` <1327944197-6379-4-git-send-email-felipec@infradead.org>
2012-01-30 17:50 ` [PATCH v2 3/4] completion: cleanup __gitcomp* Jonathan Nieder
2012-01-30 19:03 ` Junio C Hamano
2012-01-30 21:25 ` Junio C Hamano
2012-01-31 0:15 ` SZEDER Gábor
2012-01-31 0:25 ` Jonathan Nieder
[not found] ` <1327944197-6379-5-git-send-email-felipec@infradead.org>
2012-01-30 17:53 ` [PATCH v2 4/4] completion: be nicer with zsh Jonathan Nieder
2012-01-30 18:10 ` Felipe Contreras
2012-01-30 18:25 ` Jonathan Nieder
2012-01-30 18:56 ` Felipe Contreras
2012-01-30 19:03 ` Jonathan Nieder
2012-01-30 19:09 ` Junio C Hamano
2012-01-30 19:22 ` Felipe Contreras
2012-01-30 19:28 ` Jonathan Nieder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120130192834.GA28920@burratino \
--to=jrnieder@gmail.com \
--cc=felipe.contreras@gmail.com \
--cc=felipec@infradead.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=lee.marlow@gmail.com \
--cc=spearce@spearce.org \
--cc=szeder@ira.uka.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).