From: Jonathan Nieder <jrnieder@gmail.com>
To: "SZEDER Gábor" <szeder@ira.uka.de>
Cc: Felipe Contreras <felipec@infradead.org>,
git@vger.kernel.org,
Felipe Contreras <felipe.contreras@gmail.com>,
Ted Pavlic <ted@tedpavlic.com>,
"Shawn O. Pearce" <spearce@spearce.org>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v2 3/4] completion: cleanup __gitcomp*
Date: Mon, 30 Jan 2012 18:25:26 -0600 [thread overview]
Message-ID: <20120131002526.GB2678@burratino> (raw)
In-Reply-To: <20120131001535.GB2632@goldbirke>
SZEDER Gábor wrote:
> On Mon, Jan 30, 2012 at 11:50:04AM -0600, Jonathan Nieder wrote:
>> I imagine it would have been enough to say something along the lines of
>> "The __gitcomp and __gitcomp_nl functions are unnecessarily verbose.
>> __gitcomp_nl sets IFS to " \t\n" unnecessarily
>
> Yeah, that's unnecessary. I'm not sure why I did that, perhaps just
> blindly followed suit of gitcomp_1(), without realizing that I don't
> do any word-splitting in __gitcomp_nl() except when invoking compgen.
>
>> before setting it to "\n"
>> by mistake.
>
> But that is deliberate, that's why it's called __gitcomp_nl(), see
> a31e6262 (completion: optimize refs completion, 2011-10-15), third
> paragraph.
Yep, sorry for the ambiguity. I meant that setting IFS to " \t\n"
(before setting it to "\n") was not done for any serious reason.
The explanation is definitely clearer with "by mistake" dropped.
Thanks,
Jonathan
next prev parent reply other threads:[~2012-01-31 0:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-30 17:23 [PATCH 0/4] completion: trivial cleanups Felipe Contreras
2012-01-30 17:23 ` [PATCH v2 2/4] completion: remove unused code Felipe Contreras
[not found] ` <1327944197-6379-2-git-send-email-felipec@infradead.org>
2012-01-30 17:34 ` [PATCH v2 1/4] completion: simplify __git_remotes Jonathan Nieder
2012-01-30 18:27 ` Junio C Hamano
[not found] ` <1327944197-6379-4-git-send-email-felipec@infradead.org>
2012-01-30 17:50 ` [PATCH v2 3/4] completion: cleanup __gitcomp* Jonathan Nieder
2012-01-30 19:03 ` Junio C Hamano
2012-01-30 21:25 ` Junio C Hamano
2012-01-31 0:15 ` SZEDER Gábor
2012-01-31 0:25 ` Jonathan Nieder [this message]
[not found] ` <1327944197-6379-5-git-send-email-felipec@infradead.org>
2012-01-30 17:53 ` [PATCH v2 4/4] completion: be nicer with zsh Jonathan Nieder
2012-01-30 18:10 ` Felipe Contreras
2012-01-30 18:25 ` Jonathan Nieder
2012-01-30 18:56 ` Felipe Contreras
2012-01-30 19:03 ` Jonathan Nieder
2012-01-30 19:09 ` Junio C Hamano
2012-01-30 19:22 ` Felipe Contreras
2012-01-30 19:28 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120131002526.GB2678@burratino \
--to=jrnieder@gmail.com \
--cc=felipe.contreras@gmail.com \
--cc=felipec@infradead.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=spearce@spearce.org \
--cc=szeder@ira.uka.de \
--cc=ted@tedpavlic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).