git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: General support for ! in git-config values
Date: Wed, 1 Feb 2012 13:40:20 -0500	[thread overview]
Message-ID: <20120201184020.GA29374@sigill.intra.peff.net> (raw)
In-Reply-To: <CACBZZX6U+1Fmdaz2ikbbc6zUyF=pMGQOqUGVOWCkUFBUkovCBw@mail.gmail.com>

On Wed, Feb 01, 2012 at 06:33:47PM +0100, Ævar Arnfjörð Bjarmason wrote:

> For a program I'm working on (git-deploy) I'd like to have this as a
> general facility, i.e. users can specify either:
> 
>     foo.bar = value
> 
> Or:
> 
>     foo.bar = !cat /some/path
> 
> I'm wondering why git-config doesn't do this already, if there's no
> reason in particular I can just patch it in, either as a new option:
> 
>     git config --with-exec --get foo.bar

I'm not clear on what you want --with-exec to do. By default, config
values are strings. I would expect the "!" to be a special marker that
the caller would recognize in the string, and then act appropriately.

So if I were implementing git aliases in the shell, the code would look
like:

  v=$(git config alias.$alias)
  case "$v" in
  "")
          die "no such alias: $alias" ;;
  "!*)
          cmd="${v#!}" ;;
  *)
          cmd="git $v" ;;
  esac
  eval "$cmd"

I.e., everything pertaining to "!" happens after we get the config
string. So what is it that you want "git config --with-exec" to do?

-Peff

  reply	other threads:[~2012-02-01 18:40 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-01 17:33 General support for ! in git-config values Ævar Arnfjörð Bjarmason
2012-02-01 18:40 ` Jeff King [this message]
2012-02-01 21:25   ` Ævar Arnfjörð Bjarmason
2012-02-01 22:21     ` Junio C Hamano
2012-02-02  0:16       ` demerphq
2012-02-02  0:27         ` Junio C Hamano
2012-02-02  1:14           ` demerphq
2012-02-02  1:39             ` Junio C Hamano
2012-02-02  1:57               ` demerphq
2012-02-02  2:38                 ` Jeff King
2012-02-02  9:44                   ` demerphq
2012-02-02  9:54                     ` Jeff King
2012-02-02 10:21                       ` demerphq
2012-02-03  5:08                         ` Kyle Moffett
2012-02-03  6:11                           ` Junio C Hamano
2012-02-03  7:35                             ` Kyle Moffett
2012-02-03 12:13                             ` Jeff King
2012-02-03 12:09                           ` Jeff King
2012-02-02  1:41             ` Junio C Hamano
2012-02-02  2:06               ` demerphq

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120201184020.GA29374@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).