git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Kyle Moffett <kyle@moffetthome.net>
Cc: demerphq <demerphq@gmail.com>,
	"Junio C Hamano" <gitster@pobox.com>,
	"Ævar Arnfjörð" <avarab@gmail.com>,
	"Git Mailing List" <git@vger.kernel.org>
Subject: Re: General support for ! in git-config values
Date: Fri, 3 Feb 2012 07:09:36 -0500	[thread overview]
Message-ID: <20120203120936.GC31441@sigill.intra.peff.net> (raw)
In-Reply-To: <CAGZ=bq++R+X+2r2_zQ4UZ6JvDC9W9_4nF23MQ6+612_Qe2RS4Q@mail.gmail.com>

On Thu, Feb 02, 2012 at 09:08:46PM -0800, Kyle Moffett wrote:

> > I understand. I think we will probably use backtick quoting in git-deploy. So
> >
> > deploy.prefix=`cat /etc/SERVER_ROLE`
> >
> > will execute cat /etc/SERVER_ROLE and use the results as the value of
> > the config option.
> 
> Alternatively, you could extend the recent proposal for GIT config
> "include" statements so that something like this works:
> 
> [include]
>     exec = echo "deploy.prefix = `cat /etc/SERVER_ROLE`"
>     exec = /usr/local/bin/git-config-for-ldap-user
> 
> Thoughts?

I am still undecided on whether the utility of the idea is worth the
potential hassle, but syntactically I like that better. It does put a
little more burden on the called program to handle things like quoting,
though.

-Peff

  parent reply	other threads:[~2012-02-03 12:09 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-01 17:33 General support for ! in git-config values Ævar Arnfjörð Bjarmason
2012-02-01 18:40 ` Jeff King
2012-02-01 21:25   ` Ævar Arnfjörð Bjarmason
2012-02-01 22:21     ` Junio C Hamano
2012-02-02  0:16       ` demerphq
2012-02-02  0:27         ` Junio C Hamano
2012-02-02  1:14           ` demerphq
2012-02-02  1:39             ` Junio C Hamano
2012-02-02  1:57               ` demerphq
2012-02-02  2:38                 ` Jeff King
2012-02-02  9:44                   ` demerphq
2012-02-02  9:54                     ` Jeff King
2012-02-02 10:21                       ` demerphq
2012-02-03  5:08                         ` Kyle Moffett
2012-02-03  6:11                           ` Junio C Hamano
2012-02-03  7:35                             ` Kyle Moffett
2012-02-03 12:13                             ` Jeff King
2012-02-03 12:09                           ` Jeff King [this message]
2012-02-02  1:41             ` Junio C Hamano
2012-02-02  2:06               ` demerphq

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120203120936.GC31441@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=avarab@gmail.com \
    --cc=demerphq@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=kyle@moffetthome.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).