git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Ben Walton <bwalton@artsci.utoronto.ca>, git@vger.kernel.org
Subject: Re: [PATCH 2/2] t0300: use write_script helper
Date: Sat, 4 Feb 2012 02:00:09 -0500	[thread overview]
Message-ID: <20120204070009.GA22188@sigill.intra.peff.net> (raw)
In-Reply-To: <7vd39vjda9.fsf@alter.siamese.dyndns.org>

On Fri, Feb 03, 2012 at 10:58:06PM -0800, Junio C Hamano wrote:

> > diff --git a/t/t0300-credentials.sh b/t/t0300-credentials.sh
> > index 885af8f..0b46248 100755
> > --- a/t/t0300-credentials.sh
> > +++ b/t/t0300-credentials.sh
> > @@ -14,14 +14,13 @@ test_expect_success 'setup helper scripts' '
> >  	done
> >  	EOF
> >  
> > -	cat >git-credential-useless <<-\EOF &&
> > +	write_script git-credential-useless <<-\EOF &&
> >  	#!/bin/sh
> 
> An innocuous facepalm I'd be glad to remove myself ;-)

Heh, it took me a second to notice it, even after you mentioned it. And
it's even right there in the context. At least the line written by
write_script takes precedence. :)

Thanks.

-Peff

  reply	other threads:[~2012-02-04  7:00 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-02 19:32 [PATCH] t0300-credentials: Word around a solaris /bin/sh bug Ben Walton
2012-02-02 19:44 ` Frans Klaver
2012-02-02 19:48   ` Ben Walton
2012-02-02 20:02 ` Jeff King
2012-02-03  1:02   ` Junio C Hamano
2012-02-03 12:06     ` Jeff King
2012-02-03 13:45       ` Ben Walton
2012-02-03 20:32       ` Junio C Hamano
2012-02-03 21:26         ` Jeff King
2012-02-03 21:50           ` Junio C Hamano
2012-02-03 21:55             ` Jeff King
2012-02-03 22:00               ` Ben Walton
2012-02-03 22:45               ` Junio C Hamano
2012-02-03 23:27                 ` Jeff King
2012-02-04  6:27                 ` Jeff King
2012-02-04  6:29                   ` [PATCH 1/2] tests: add write_script helper function Jeff King
2012-02-04  6:30                   ` [PATCH 2/2] t0300: use write_script helper Jeff King
2012-02-04  6:58                     ` Junio C Hamano
2012-02-04  7:00                       ` Jeff King [this message]
2012-02-02 20:16 ` [PATCH] t0300-credentials: Word around a solaris /bin/sh bug Jonathan Nieder
2012-02-02 20:43   ` Matthieu Moy
2012-02-02 21:11     ` Jonathan Nieder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120204070009.GA22188@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=bwalton@artsci.utoronto.ca \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).