From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Michael Haggerty <mhagger@alum.mit.edu>
Subject: Re: [PATCH] branch --edit-description: protect against mistyped branch name
Date: Sun, 5 Feb 2012 23:20:43 -0500 [thread overview]
Message-ID: <20120206042043.GC29365@sigill.intra.peff.net> (raw)
In-Reply-To: <7vaa4wda60.fsf_-_@alter.siamese.dyndns.org>
On Sun, Feb 05, 2012 at 05:26:31PM -0800, Junio C Hamano wrote:
> This incidentally also errors out --edit-description when the HEAD points
> at an unborn branch (immediately after "init", or "checkout --orphan"),
> because at that point, you do not even have any commit that is part of
> your history and there is no point in describing how this particular
> branch is different from the branch it forked off of, which is the useful
> bit of information the branch description is designed to capture.
>
> We may want to special case the unborn case later, but that is outside the
> scope of this patch to prevent more common mistakes before 1.7.9 series
> gains too much widespread use.
That sounds OK to me. I'm not even sure people will want to use
"--edit-description" on an unborn pointed-to branch or not (I mentioned
it only as "this is a plausible use case to me that we might be
breaking"). I think people will still be figuring out workflows around
it. So it's not a big deal to wait and see.
-Peff
next prev parent reply other threads:[~2012-02-06 4:20 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-29 6:09 Bug: "git checkout -b" should be allowed in empty repo Michael Haggerty
2012-01-29 6:56 ` Junio C Hamano
2012-01-29 7:50 ` Junio C Hamano
2012-01-30 6:38 ` Michael Haggerty
2012-01-30 18:48 ` Junio C Hamano
2012-01-30 20:10 ` Junio C Hamano
2012-01-30 21:50 ` Jeff King
2012-02-06 2:06 ` Junio C Hamano
2012-02-06 2:08 ` Junio C Hamano
2012-02-06 4:30 ` Jeff King
2012-02-06 4:42 ` Andrew Ardill
2012-02-06 5:06 ` Jeff King
2012-02-06 8:51 ` Michael Haggerty
2012-02-06 8:57 ` Jeff King
2012-02-06 18:17 ` Junio C Hamano
2012-02-06 20:14 ` Jeff King
2012-02-07 8:04 ` Michael Haggerty
2012-02-06 18:39 ` demerphq
2012-02-06 5:15 ` Junio C Hamano
2012-02-06 5:18 ` Jeff King
2012-02-06 5:30 ` Junio C Hamano
2012-02-06 5:34 ` Junio C Hamano
2012-02-06 5:45 ` Jeff King
2012-02-06 8:59 ` Michael Haggerty
2012-02-06 18:31 ` Junio C Hamano
2012-01-30 21:48 ` Jeff King
2012-02-06 1:26 ` [PATCH] branch --edit-description: protect against mistyped branch name Junio C Hamano
2012-02-06 1:27 ` Junio C Hamano
2012-02-06 4:20 ` Jeff King [this message]
2012-01-31 8:57 ` Bug: "git checkout -b" should be allowed in empty repo Michael Haggerty
2012-01-31 10:01 ` Johannes Sixt
2012-01-31 10:11 ` demerphq
2012-01-31 10:09 ` Jakub Narebski
2012-01-31 16:32 ` Michael Haggerty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120206042043.GC29365@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mhagger@alum.mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).