From: Jeff King <peff@peff.net>
To: Nicholas Harteau <nrh@ikami.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] perl/Makefile: use 'installsitelib' even with NO_PERL_MAKEMAKER
Date: Mon, 6 Feb 2012 15:34:29 -0500 [thread overview]
Message-ID: <20120206203429.GA31404@sigill.intra.peff.net> (raw)
In-Reply-To: <9D199309-85A6-42EE-9417-8C4E61534670@spotify.com>
On Mon, Feb 06, 2012 at 03:30:54PM -0500, Nicholas Harteau wrote:
> >>> ifdef NO_PERL_MAKEMAKER
> >>> -instdir_SQ = $(subst ','\'',$(prefix)/lib)
> >>> +instdir_SQ = $(subst ','\'',$(subst installsitelib=,'',$(shell $(PERL_PATH_SQ) -V:installsitelib)))
> >
> > Isn't this a regression if I am a non-root user installing into
> > $HOME/local or similar? With MakeMaker, I end up with this in my
> > perl.mak:
> [...]
>
> Totally correct - let me re-think the non-root case. Thanks.
I just read the github PR you linked to. It sounds like it might work to
just add a knob that the homebrew recipe could tweak to enable this
behavior (with the knob off by default).
-Peff
prev parent reply other threads:[~2012-02-06 20:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-30 10:51 [PATCH] use 'installsitelib' even with NO_PERL_MAKEMAKER Nicholas Harteau
2012-02-06 19:38 ` [PATCH] perl/Makefile: " Nicholas Harteau
2012-02-06 20:26 ` Jeff King
2012-02-06 20:30 ` Nicholas Harteau
2012-02-06 20:34 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120206203429.GA31404@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=nrh@ikami.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).