git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Michał Kiedrowicz" <michal.kiedrowicz@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [BUG] git-merge-octopus creates an empty merge commit with one parent
Date: Mon, 13 Feb 2012 20:20:39 +0100	[thread overview]
Message-ID: <20120213202039.5346fa89@gmail.com> (raw)
In-Reply-To: <7vipjafu27.fsf@alter.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> wrote:

> Michał Kiedrowicz <michal.kiedrowicz@gmail.com> writes:
> 
> > This happens when git merge is run to merge multiple commits that are
> > descendants of current HEAD (or are HEAD).
> 
> I am reasonably sure you meant ancestors here.

I meant: ... to merge commits whose parent, grand-parent or
grand-grand-...-parent is HEAD. Commits to which HEAD may be
fast-forwarded.

> 
> > to origin/master but accidentaly we called (while being on master):
> >
> > 	$ git merge master origin/master
> 
> I am very tempted to throw this into "don't do it then" category.

I'm all for it. This is not a thing I would want to be doing. At
no time I would call this "a serious bug that needs fixing right
now". Except that I still think this behavior is not correct. git-merge
should not create commits that even aren't merges (they have single
parrent) and have exactly the same tree as its parent, and give it a
message "merge". Isn't this against the normal behavior of Git:
forwarding if possible and refusing to create commits that don't change
any file?

  reply	other threads:[~2012-02-13 19:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-13 11:48 [BUG] git-merge-octopus creates an empty merge commit with one parent Michał Kiedrowicz
2012-02-13 18:48 ` Junio C Hamano
2012-02-13 19:20   ` Michał Kiedrowicz [this message]
2012-02-13 19:51     ` Junio C Hamano
2012-02-13 20:53       ` Michał Kiedrowicz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120213202039.5346fa89@gmail.com \
    --to=michal.kiedrowicz@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).