git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [RFC PATCH 0/3] git-p4: move to toplevel
@ 2012-02-12 18:13 Pete Wyckoff
  2012-02-12 18:13 ` [RFC PATCH 1/3] " Pete Wyckoff
                   ` (4 more replies)
  0 siblings, 5 replies; 16+ messages in thread
From: Pete Wyckoff @ 2012-02-12 18:13 UTC (permalink / raw)
  To: git; +Cc: Luke Diamand, Vitor Antunes

The git-p4 code is in a single python script down in
contrib/fast-import now.  I'd like to move it up to the top-level
source directory of git to make it easier to build and
distribute.  Git-p4 already takes advantage of the git
infrastructure for documentation and testing, as well as the
community support (Junio, many reviewers).

Users install git-p4 currently by copying the git-p4 script from
contrib/fast-import into a local or personal bin directory, and
setting up an alias for "git p4" to invoke it.  If it is part of
the install, the command will be available automatically.  Also,
distributions may be more likely to pick it up either as part of
a core git package, or as a separate add-on.  Getting support
for python and git-p4 in msysgit is something I'd like to see
happen too.

While I considered taking this opportunity to split up git-p4
into more modular components across multiple files, it seems best
now just to do the script move intact.  That effort could come
later.  If anyone has a strong preference to do this now, we could.

Developer note:  Like all scripts in git, the source file is
git-p4.py, which is built with "make" to git-p4, substituting the
specified path for python in the first line.  Be sure to edit the
source file, and to build before running tests.  This is sort of
a pain for existing developers, but hopefully we can get used to it.


Pete Wyckoff (3):
  git-p4: move to toplevel
  git p4: update name in script
  git p4: use "git p4" directly in tests

 .gitignore                              |    1 +
 Documentation/git-p4.txt                |   23 +++------
 INSTALL                                 |    3 +
 Makefile                                |    1 +
 contrib/fast-import/git-p4.README       |   13 +++++
 contrib/fast-import/git-p4.bat          |    1 -
 contrib/fast-import/git-p4 => git-p4.py |   14 +++---
 t/lib-git-p4.sh                         |    8 +--
 t/t9800-git-p4-basic.sh                 |   84 +++++++++++++++---------------
 t/t9801-git-p4-branch.sh                |   32 ++++++------
 t/t9802-git-p4-filetype.sh              |   10 ++--
 t/t9803-git-p4-shell-metachars.sh       |   12 ++--
 t/t9804-git-p4-label.sh                 |    6 +-
 t/t9805-git-p4-skip-submit-edit.sh      |   22 ++++----
 t/t9806-git-p4-options.sh               |   28 +++++-----
 t/t9807-git-p4-submit.sh                |   22 ++++----
 t/t9808-git-p4-chdir.sh                 |    6 +-
 t/t9809-git-p4-client-view.sh           |   64 ++++++++++++------------
 18 files changed, 179 insertions(+), 171 deletions(-)
 create mode 100644 contrib/fast-import/git-p4.README
 delete mode 100644 contrib/fast-import/git-p4.bat
 rename contrib/fast-import/git-p4 => git-p4.py (99%)

-- 
1.7.9.192.ga1d4b

^ permalink raw reply	[flat|nested] 16+ messages in thread

end of thread, other threads:[~2012-02-14 19:57 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-12 18:13 [RFC PATCH 0/3] git-p4: move to toplevel Pete Wyckoff
2012-02-12 18:13 ` [RFC PATCH 1/3] " Pete Wyckoff
2012-02-12 18:13 ` [RFC PATCH 2/3] git p4: update name in script Pete Wyckoff
2012-02-12 18:13 ` [RFC PATCH 3/3] git p4: use "git p4" directly in tests Pete Wyckoff
2012-02-12 18:54 ` [RFC PATCH 0/3] git-p4: move to toplevel Luke Diamand
2012-02-13  6:17   ` Junio C Hamano
2012-02-13 23:37     ` Pete Wyckoff
2012-02-13 20:00 ` Junio C Hamano
2012-02-13 20:37   ` Clemens Buchacher
2012-02-13 21:20     ` Junio C Hamano
2012-02-13 23:32       ` Pete Wyckoff
2012-02-14  9:20       ` Clemens Buchacher
2012-02-14 18:40         ` Junio C Hamano
2012-02-14 19:05           ` Jeff King
2012-02-14 19:25             ` Junio C Hamano
2012-02-14 19:49             ` Clemens Buchacher

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).