From: Jonathan Nieder <jrnieder@gmail.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v3 0/2] test: tests for the "double > from mailmap" bug
Date: Tue, 14 Feb 2012 16:21:28 -0600 [thread overview]
Message-ID: <20120214222128.GA24544@burratino> (raw)
In-Reply-To: <CAMP44s1mV2cE=R49qYSLd8eZPhCpRx0hRnnG_-K3iBxp_YQEpQ@mail.gmail.com>
Felipe Contreras wrote:
> The difference of opinion is that I consider the patch already good
> enough (adding the comments from Junio).
Ok, I can understand where you're coming from there.
Now I have offered some suggestions for improving some of your
patches. Applying these suggestions would be effortless, since I sent
them in patch form. What is your response? You send a point-by-point
rebuttal explaining how each detail of my suggestions is bad, bad,
bad, and then resend the original with comparatively small changes.
Can you see how this might indicate a stronger difference of opinion
than you have mentioned? And how a reviewer might make the mistake of
thinking his comments were unwelcome after such an experience?
next prev parent reply other threads:[~2012-02-14 22:21 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-14 16:11 [PATCH 0/2] t: add blame -e tests for mailmap Felipe Contreras
2012-02-14 16:11 ` [PATCH 1/2] t: mailmap: add 'git blame -e' tests Felipe Contreras
2012-02-14 16:11 ` [PATCH 2/2] t: mailmap: add simple name translation test Felipe Contreras
2012-02-14 20:10 ` Junio C Hamano
2012-02-14 20:28 ` Felipe Contreras
2012-02-14 20:34 ` [PATCH v3 0/2] test: tests for the "double > from mailmap" bug Jonathan Nieder
2012-02-14 20:35 ` [PATCH 1/2] test: mailmap can change author name without changing email Jonathan Nieder
2012-02-14 21:35 ` Felipe Contreras
2012-02-14 21:50 ` Jonathan Nieder
2012-02-14 22:48 ` Felipe Contreras
2012-02-14 20:36 ` [PATCH 2/2] test: check that "git blame -e" uses mailmap correctly Jonathan Nieder
2012-02-14 21:41 ` Felipe Contreras
2012-02-14 21:59 ` Jonathan Nieder
2012-02-14 22:56 ` Felipe Contreras
2012-02-14 21:06 ` [PATCH v3 0/2] test: tests for the "double > from mailmap" bug Felipe Contreras
2012-02-14 21:15 ` Jonathan Nieder
2012-02-14 22:09 ` Felipe Contreras
2012-02-14 22:21 ` Jonathan Nieder [this message]
2012-02-14 22:36 ` Felipe Contreras
2012-02-14 21:14 ` Jeff King
2012-02-14 21:27 ` Jonathan Nieder
2012-02-14 21:52 ` Felipe Contreras
2012-02-14 22:07 ` Jeff King
2012-02-14 22:22 ` Felipe Contreras
2012-02-14 22:35 ` Jeff King
2012-02-14 22:18 ` Junio C Hamano
2012-02-14 22:34 ` Felipe Contreras
2012-02-14 22:49 ` Junio C Hamano
2012-02-14 23:14 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120214222128.GA24544@burratino \
--to=jrnieder@gmail.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).