From: Jeff King <peff@peff.net>
To: mhagger@alum.mit.edu
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, Jakub Narebski <jnareb@gmail.com>,
Heiko Voigt <hvoigt@hvoigt.net>,
Johan Herland <johan@herland.net>
Subject: Re: [PATCH 0/7] Make alternates affect fetch behavior
Date: Tue, 14 Feb 2012 17:51:13 -0500 [thread overview]
Message-ID: <20120214225113.GA25558@sigill.intra.peff.net> (raw)
In-Reply-To: <1328941261-29746-1-git-send-email-mhagger@alum.mit.edu>
On Sat, Feb 11, 2012 at 07:20:54AM +0100, mhagger@alum.mit.edu wrote:
> It used to be that alternate references were not considered "complete"
> when fetching via fetch-pack. This failure was not so obvious because
> the big benefit of alternates is seen when cloning, and clone used a
> different data path: it put the alternate references into extra refs
> (which makes them look like references within the local repository).
>
> This patch series teaches fetch-pack to treat objects that are
> available via alternates as "complete".
>
> Once that is fixed, clone doesn't need to use the special extra_refs
> kludge, so change that.
>
> And once that is changed, the extra_refs API is no longer needed at
> all, so remove it.
>
> Michael Haggerty (7):
> t5700: document a failure of alternates to affect fetch
> clone.c: move more code into the "if (refs)" conditional
> fetch-pack.c: rename some parameters from "path" to "refname"
> fetch-pack.c: inline insert_alternate_refs()
> everything_local(): mark alternate refs as complete
> clone: do not add alternate references to extra_refs
> refs: remove the extra_refs API
>From my reading, all of these patches look good. Thanks for a
well-organized series.
-Peff
prev parent reply other threads:[~2012-02-14 22:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-11 6:20 [PATCH 0/7] Make alternates affect fetch behavior mhagger
2012-02-11 6:20 ` [PATCH 1/7] t5700: document a failure of alternates to affect fetch mhagger
2012-02-13 3:35 ` Junio C Hamano
2012-02-13 4:45 ` Michael Haggerty
2012-02-11 6:20 ` [PATCH 2/7] clone.c: move more code into the "if (refs)" conditional mhagger
2012-02-13 3:35 ` Junio C Hamano
2012-02-11 6:20 ` [PATCH 3/7] fetch-pack.c: rename some parameters from "path" to "refname" mhagger
2012-02-13 3:47 ` Junio C Hamano
2012-02-11 6:20 ` [PATCH 4/7] fetch-pack.c: inline insert_alternate_refs() mhagger
2012-02-11 6:20 ` [PATCH 5/7] everything_local(): mark alternate refs as complete mhagger
2012-02-11 6:21 ` [PATCH 6/7] clone: do not add alternate references to extra_refs mhagger
2012-02-13 4:00 ` Junio C Hamano
2012-02-11 6:21 ` [PATCH 7/7] refs: remove the extra_refs API mhagger
2012-02-14 22:51 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120214225113.GA25558@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=hvoigt@hvoigt.net \
--cc=jnareb@gmail.com \
--cc=johan@herland.net \
--cc=mhagger@alum.mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).