From: Jeff King <peff@peff.net>
To: Thomas Rast <trast@inf.ethz.ch>
Cc: Junio C Hamano <gitster@pobox.com>,
Thomas Rast <trast@student.ethz.ch>,
git@vger.kernel.org,
Jannis Pohlmann <jannis.pohlmann@codethink.co.uk>
Subject: Re: [PATCH 2/2] bundle: use a strbuf to scan the log for boundary commits
Date: Wed, 22 Feb 2012 16:00:00 -0500 [thread overview]
Message-ID: <20120222210000.GE6781@sigill.intra.peff.net> (raw)
In-Reply-To: <87hayivcmm.fsf@thomas.inf.ethz.ch>
On Wed, Feb 22, 2012 at 09:25:53PM +0100, Thomas Rast wrote:
> > Thanks for diagnosing this, but I wonder if it even needs --pretty=oneline
> > to begin with, except for debugging purposes.
> >
> > Do we ever use the subject string read from the rev-list output in any
> > way?
> >
> > In other words, I am wondering if the right patch to minimally fix the
> > issue starting from older releases is something along this line instead:
>
> Not sure. The only use I could think of would be to google for the
> subjects, in the hope of finding some repository that has the commit you
> are looking for. Other than that...
Or because the bundle creator (which may even be you on a different day)
did not correctly guess at the negative refs when specifying a cutoff.
Assuming you no longer have access to the original repo (not
unreasonable, since you are using a bundle), the messages could help you
understand where the error occurred.
Of course, once you figure out "aha! I expected the bundle to include
foo, but it is actually a cutoff point. I should have said XYZ^ as the
cutoff", I'm not sure what you do then. It's not like there is an easy
way to salvage the data that is in the bundle.
So I think it is a debugging aid, but one that ultimately doesn't help
you that much.
-Peff
next prev parent reply other threads:[~2012-02-22 21:00 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-22 16:05 Problems with unrecognized headers in git bundles Jannis Pohlmann
2012-02-22 19:34 ` [PATCH 1/2] bundle: put strbuf_readline_fd in strbuf.c with adjustments Thomas Rast
2012-02-22 19:34 ` [PATCH 2/2] bundle: use a strbuf to scan the log for boundary commits Thomas Rast
2012-02-22 20:22 ` Junio C Hamano
2012-02-22 20:25 ` Thomas Rast
2012-02-22 20:50 ` Junio C Hamano
2012-02-22 21:00 ` Jeff King [this message]
2012-02-22 20:55 ` Jeff King
2012-02-22 22:10 ` Johannes Sixt
2012-02-23 3:20 ` Junio C Hamano
2012-02-23 3:38 ` Junio C Hamano
2012-02-23 9:42 ` [PATCH v2 0/4] Making an elephant out of a getline() bug Thomas Rast
2012-02-23 9:42 ` [PATCH v2 1/4] strbuf: improve strbuf_get*line documentation Thomas Rast
2012-02-23 10:08 ` Jeff King
2012-02-23 9:42 ` [PATCH v2 2/4] bundle: put strbuf_readline_fd in strbuf.c with adjustments Thomas Rast
2012-02-23 9:42 ` [PATCH v2 3/4] t5704: match tests to modern style Thomas Rast
2012-02-23 23:36 ` Junio C Hamano
2012-02-23 9:42 ` [PATCH v2 4/4] bundle: use a strbuf to scan the log for boundary commits Thomas Rast
2012-02-23 19:04 ` [PATCH v2 0/4] Making an elephant out of a getline() bug Junio C Hamano
2012-02-22 20:51 ` [PATCH 1/2] bundle: put strbuf_readline_fd in strbuf.c with adjustments Jeff King
2012-02-22 20:25 ` Problems with unrecognized headers in git bundles Øyvind A. Holm
2012-02-22 20:40 ` Øyvind A. Holm
2012-02-23 13:27 ` Erik Faye-Lund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120222210000.GE6781@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jannis.pohlmann@codethink.co.uk \
--cc=trast@inf.ethz.ch \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).