git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Nikolaj Shurkaev <snnicky@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
	Jakub Narebski <jnareb@gmail.com>,
	git@vger.kernel.org
Subject: Re: git log -z doesn't separate commits with NULs
Date: Fri, 24 Feb 2012 04:52:53 -0500	[thread overview]
Message-ID: <20120224095253.GC11846@sigill.intra.peff.net> (raw)
In-Reply-To: <4F475689.4040203@gmail.com>

On Fri, Feb 24, 2012 at 12:21:13PM +0300, Nikolaj Shurkaev wrote:

> I'll propose to put something like this into git documentation
> --------------------------------------------------------------------------------------------
> diff --git a/Documentation/git-format-patch.txt
> b/Documentation/git-format-patch.txt
> index 6ea9be7..63267c6 100644
> --- a/Documentation/git-format-patch.txt
> +++ b/Documentation/git-format-patch.txt
> @@ -23,6 +23,7 @@ SYNOPSIS
> [--cover-letter] [--quiet]
> [<common diff options>]
> [ <since> | <revision range> ]
> + [[\--] <path>...]
> 
> DESCRIPTION
> -----------
> @@ -219,6 +220,12 @@ you can use `--suffix=-patch` to get
> `0001-description-of-my-change-patch`.
> range are always formatted as creation patches, independently
> of this flag.
> 
> +[\--] <path>...::
> + Put in patches only those modifications that affect specified files
> + and folders. It's important to understand that log message of the
> + commit may become inappropriate because some parts of patch may be
> + cut off.
> +

I think that text looks OK. But to my mind, it is not that format-patch
accepts a path parameter, but rather that it takes arbitrary log-like
arguments. So you could do "git format-patch --grep=whatever", or even
something like "git format-patch --cherry".

I don't know how well tested every option is, though, so maybe it's not
a good idea to encourage the use of random options.

-Peff

  reply	other threads:[~2012-02-24  9:53 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-23  9:14 git log -z doesn't separate commits with NULs Nikolaj Shurkaev
2012-02-23 10:02 ` Luke Diamand
2012-02-23 10:27   ` Jeff King
2012-02-23 10:17 ` Johannes Sixt
2012-02-23 12:11   ` Nikolaj Shurkaev
2012-02-23 10:24 ` Jeff King
2012-02-23 12:17   ` Nikolaj Shurkaev
2012-02-23 13:15     ` Jakub Narebski
2012-02-23 13:48       ` Nikolaj Shurkaev
2012-02-23 19:34         ` Jeff King
2012-02-23 20:07           ` Junio C Hamano
2012-02-24  9:21             ` Nikolaj Shurkaev
2012-02-24  9:52               ` Jeff King [this message]
2012-02-24 20:03                 ` Junio C Hamano
2012-02-24 20:46                   ` Jeff King
2012-02-24 21:14                     ` Junio C Hamano
2012-02-24 21:16                       ` Jeff King
2012-03-03 13:41                         ` Nikolaj Shurkaev
2012-02-24 22:11                       ` Jakub Narebski
2012-02-24 22:27                         ` Junio C Hamano
2012-02-23 10:35 ` Andreas Schwab
2012-02-23 12:19   ` Nikolaj Shurkaev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120224095253.GC11846@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jnareb@gmail.com \
    --cc=snnicky@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).