From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Nikolaj Shurkaev <snnicky@gmail.com>,
Jakub Narebski <jnareb@gmail.com>,
git@vger.kernel.org
Subject: Re: git log -z doesn't separate commits with NULs
Date: Fri, 24 Feb 2012 16:16:58 -0500 [thread overview]
Message-ID: <20120224211658.GA30922@sigill.intra.peff.net> (raw)
In-Reply-To: <7vk43cx7c2.fsf@alter.siamese.dyndns.org>
On Fri, Feb 24, 2012 at 01:14:05PM -0800, Junio C Hamano wrote:
> > True. That is also a slightly dangerous thing to do, though, because you
> > are omitting full patches in the middle that touch the same paths as the
> > patches you include....
> > ... So
> > perhaps we are better off to refer the user to git-log(1), say that
> > commit limiting options in general would work, but be careful with
> > sending a partial result.
>
> You seem to have spelled out everything I originally wrote in my reply
> that I later deleted before sending it out, and I think the reason that
> brought you to the three-line conclusion is the same one that made me I
> delete them ;-).
OK, good. :)
Nikolaj, have you followed all of this? Do you want to try to improve
your patch in this direction?
-Peff
next prev parent reply other threads:[~2012-02-24 21:17 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-23 9:14 git log -z doesn't separate commits with NULs Nikolaj Shurkaev
2012-02-23 10:02 ` Luke Diamand
2012-02-23 10:27 ` Jeff King
2012-02-23 10:17 ` Johannes Sixt
2012-02-23 12:11 ` Nikolaj Shurkaev
2012-02-23 10:24 ` Jeff King
2012-02-23 12:17 ` Nikolaj Shurkaev
2012-02-23 13:15 ` Jakub Narebski
2012-02-23 13:48 ` Nikolaj Shurkaev
2012-02-23 19:34 ` Jeff King
2012-02-23 20:07 ` Junio C Hamano
2012-02-24 9:21 ` Nikolaj Shurkaev
2012-02-24 9:52 ` Jeff King
2012-02-24 20:03 ` Junio C Hamano
2012-02-24 20:46 ` Jeff King
2012-02-24 21:14 ` Junio C Hamano
2012-02-24 21:16 ` Jeff King [this message]
2012-03-03 13:41 ` Nikolaj Shurkaev
2012-02-24 22:11 ` Jakub Narebski
2012-02-24 22:27 ` Junio C Hamano
2012-02-23 10:35 ` Andreas Schwab
2012-02-23 12:19 ` Nikolaj Shurkaev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120224211658.GA30922@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jnareb@gmail.com \
--cc=snnicky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).