From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/2] do not stream large files to pack when filters are in use
Date: Fri, 24 Feb 2012 16:19:13 -0500 [thread overview]
Message-ID: <20120224211913.GA30942@sigill.intra.peff.net> (raw)
In-Reply-To: <20120224204810.GC21447@sigill.intra.peff.net>
On Fri, Feb 24, 2012 at 03:48:10PM -0500, Jeff King wrote:
> > By the way, I tried this with the tip of 'pu' as of last night, and the
> > result segfaults on me in t1050 (hash-object -w) ;-).
>
> Eek. I ran through "make test" on my finished series without a problem,
> but it may be a bad interaction with something in "pu", or maybe a
> heisenbug. I'll investigate.
Or maybe I'm just an idiot, and apparently didn't actually run the test
suite correctly. Because it is very reproducible, and is because
hash-object --stdin passes a NULL for the path.
I'll post the fixed series in a minute (with this fix, and the improved
convert_to_git wrapper).
-Peff
next prev parent reply other threads:[~2012-02-24 21:19 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-24 3:02 [BUG?] bulk checkin does not respect filters Jeff King
2012-02-24 3:17 ` Junio C Hamano
2012-02-24 3:42 ` Junio C Hamano
2012-02-24 7:54 ` Jeff King
2012-02-24 18:48 ` Junio C Hamano
2012-02-24 8:28 ` Jeff King
2012-02-24 9:39 ` Jeff King
2012-02-24 9:41 ` [PATCH 1/2] teach convert_to_git a "dry run" mode Jeff King
2012-02-24 9:48 ` [PATCH 2/2] do not stream large files to pack when filters are in use Jeff King
2012-02-24 20:03 ` Junio C Hamano
2012-02-24 20:48 ` Jeff King
2012-02-24 21:01 ` Jeff King
2012-02-24 21:20 ` Junio C Hamano
2012-02-24 21:19 ` Jeff King [this message]
2012-02-24 22:02 ` [PATCHv2 1/3] teach convert_to_git a "dry run" mode Jeff King
2012-02-24 22:05 ` [PATCHv2 2/3] teach dry-run convert_to_git not to require a src buffer Jeff King
2012-02-24 22:10 ` [PATCHv2 3/3] do not stream large files to pack when filters are in use Jeff King
2012-02-24 22:42 ` [PATCH 2/2] " Junio C Hamano
2012-02-24 20:03 ` [BUG?] bulk checkin does not respect filters Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120224211913.GA30942@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).