From: Pete Wyckoff <pw@padd.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, "Laurent Charrière" <lcharriere@promptu.com>
Subject: Re: [PATCH 0/2] git-p4: fix submit regression with --use-client-spec
Date: Sun, 26 Feb 2012 19:25:14 -0500 [thread overview]
Message-ID: <20120227002514.GA31028@padd.com> (raw)
In-Reply-To: <7vhaydcenz.fsf@alter.siamese.dyndns.org>
gitster@pobox.com wrote on Sun, 26 Feb 2012 16:18 -0800:
> Pete Wyckoff <pw@padd.com> writes:
>
> > This pair of patches fixes a regression that happened with ecb7cf9
> > (git-p4: rewrite view handling, 2012-01-02). There are two factors that
> > affect where files go in the client when submitting: the cilent spec,
> > and the depot path. When the depot path was not exactly the root of
> > the client, submit fails.
> >
> > Fix this by always using the true client root. And also notice that
> > somebody has to tell the submit path that it should be looking at the
> > cilent spec. Save useClientSpec in a configuration variable if it
> > was specified as an option on the command line.
> >
> > Junio: can you put this on maint to go out with the next 1.9.x?
>
> Surely and thanks.
>
> Your "p4: submit with wildcards" seems to conflict with this change and
> may need to be rebased, though.
Ah, yes. The conflicting chunks can be added in any order above
class P4Command. I'll rebase and resend in a few days, after
waiting for review comments.
-- Pete
prev parent reply other threads:[~2012-02-27 0:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-26 1:06 [PATCH 0/2] git-p4: fix submit regression with --use-client-spec Pete Wyckoff
2012-02-26 1:06 ` [PATCH 1/2] git-p4: set useClientSpec variable on initial clone Pete Wyckoff
2012-02-26 1:06 ` [PATCH 2/2] git-p4: fix submit regression with clientSpec and subdir clone Pete Wyckoff
2012-02-27 0:18 ` [PATCH 0/2] git-p4: fix submit regression with --use-client-spec Junio C Hamano
2012-02-27 0:25 ` Pete Wyckoff [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120227002514.GA31028@padd.com \
--to=pw@padd.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=lcharriere@promptu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).