From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: "David A. Greene" <greened@obbligato.org>,
Avery Pennarun <apenwarr@gmail.com>,
git@vger.kernel.org
Subject: Re: git-subtree Ready #2
Date: Mon, 27 Feb 2012 16:21:57 -0500 [thread overview]
Message-ID: <20120227212157.GA19779@sigill.intra.peff.net> (raw)
In-Reply-To: <7vobsk56md.fsf@alter.siamese.dyndns.org>
On Mon, Feb 27, 2012 at 01:06:02PM -0800, Junio C Hamano wrote:
> >>> I'm happy to do either (rebase or filter-branch). Just let me know.
> >>
> >> I would understand Avery's "should we filter-branch/rebase, or is it OK
> >> as-is?", but I do not understand what you mean by "either rebase or
> >> filter-branch is fine".
> >
> > Sorry, got mixed up there. I'm not that familiar with filter-branch.
> > Now I understand you do both. :)
> >
> > So have we decided to keep the history?
>
> I think the discussion so far was:
>
> - Peff suggested to keep the history with a true merge;
>
> - I said the history before the final commit in Avery's tree did not look
> so useful for future archaeology; and then
>
> - Avery corrected me that there are contributions by other people and the
> credits will be lost if we discarded the history;
>
> and everybody (including me) now favors to have the history.
>
> So the answer to your question is yes, but I do not think we heard opinion
> from anybody regarding the question by Avery yet. I personally do not see
> how it would help us if the old history is rewritten at this point.
Yeah, I don't see much point in rewriting. If parts of the history suck,
then so be it. It's probably not that big to store. And while it's
sometimes easier to fix bad commit messages when they are recent and in
your memory (rather than trying to remember later what you meant to
say), I think it is already too late for that. Any archaeology you do
now to make good commit messages could probably just as easily be done
if and when somebody actually needs the commit message later (emphasis
on the "if" -- it's likely that nobody will care about most of the
commit messages later at all).
-Peff
next prev parent reply other threads:[~2012-02-27 21:22 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-11 17:35 git-subtree Ready #2 David A. Greene
2012-02-11 18:03 ` Junio C Hamano
2012-02-11 19:22 ` David A. Greene
2012-02-15 4:30 ` David A. Greene
2012-02-15 5:08 ` Jeff King
2012-02-15 5:31 ` David A. Greene
2012-02-16 4:07 ` David A. Greene
2012-02-20 19:34 ` David A. Greene
2012-02-20 20:53 ` Jeff King
2012-02-20 23:14 ` Junio C Hamano
2012-02-21 5:37 ` David A. Greene
2012-02-21 6:34 ` Junio C Hamano
2012-02-21 7:10 ` Junio C Hamano
2012-02-21 8:44 ` Junio C Hamano
2012-02-21 9:07 ` Thomas Rast
2012-02-24 1:19 ` Avery Pennarun
2012-02-24 20:56 ` Junio C Hamano
2012-02-24 23:57 ` Avery Pennarun
2012-02-25 5:00 ` David A. Greene
2012-02-25 9:00 ` Junio C Hamano
2012-02-25 15:00 ` David A. Greene
2012-02-27 21:06 ` Junio C Hamano
2012-02-27 21:21 ` Jeff King [this message]
2012-02-27 21:23 ` Jeff King
2012-02-28 2:04 ` Jakub Narebski
2012-02-28 22:42 ` Avery Pennarun
2012-03-02 3:42 ` David A. Greene
2012-02-21 5:31 ` David A. Greene
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120227212157.GA19779@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=apenwarr@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=greened@obbligato.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).