git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Clemens Buchacher <drizzd@aon.at>
To: Jeff King <peff@peff.net>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] fsck: do not print dangling objects by default
Date: Mon, 27 Feb 2012 23:18:24 +0100	[thread overview]
Message-ID: <20120227221820.GA1194@ecki> (raw)
In-Reply-To: <20120227213304.GB19779@sigill.intra.peff.net>

On Mon, Feb 27, 2012 at 04:33:04PM -0500, Jeff King wrote:
> On Mon, Feb 27, 2012 at 10:13:16PM +0100, Clemens Buchacher wrote:
> 
> > > Yes, that was certainly part of my pros-and-cons analysis.  If you run
> > > "git fsck" without "--no-dangling" without reading the manual, you may
> > > get confused, but that is *not* the primary audience.
> > 
> > It is not my only concern that users might be confused. I believe the
> > command prints a lot of useless messages, which is by itself a UI
> > deficiency. But even worse, those numerous messages tend to hide an
> > actual problem in a long scrollback buffer. Sometimes my scrollback
> > buffer is not even large enough and I have to re-run fsck (which is not
> > exactly a fast command), just so I can grep out the dangling blobs.
> 
> Yeah, but doesn't adding "--no-dangling" solve that issue?

I can just as well use grep -v ^dangling.

  reply	other threads:[~2012-02-27 22:26 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-26 20:43 [PATCH] fsck: do not print dangling objects by default Clemens Buchacher
2012-02-26 21:57 ` Junio C Hamano
2012-02-26 22:46   ` Junio C Hamano
2012-02-27  6:42     ` Zbigniew Jędrzejewski-Szmek
2012-02-27 19:18     ` Jeff King
2012-02-27 19:29       ` Junio C Hamano
2012-02-27 21:13         ` Clemens Buchacher
2012-02-27 21:33           ` Jeff King
2012-02-27 22:18             ` Clemens Buchacher [this message]
2012-02-27 21:34           ` Junio C Hamano
2012-02-28 23:25             ` [PATCH] fsck: --no-dangling omits "dangling object" information Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120227221820.GA1194@ecki \
    --to=drizzd@aon.at \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).