From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Nelson Benitez Leon <nelsonjesus.benitez@seap.minhap.es>,
git@vger.kernel.org, sam@vilain.net
Subject: Re: [PATCH v2 2/3] http: try http_proxy env var when http.proxy config option is not set
Date: Thu, 1 Mar 2012 16:01:29 -0500 [thread overview]
Message-ID: <20120301210129.GD17631@sigill.intra.peff.net> (raw)
In-Reply-To: <7vy5rkm91t.fsf@alter.siamese.dyndns.org>
On Thu, Mar 01, 2012 at 11:10:38AM -0800, Junio C Hamano wrote:
> Nelson Benitez Leon <nelsonjesus.benitez@seap.minhap.es> writes:
>
> > CuRL already reads it, but if $http_proxy has username but no password
> > curl will not ask you for the password.. so we read it ourselves to
> > detect that and ask for the password.
>
> Please stop the double-dot. Also your capitalization for cURL is screwed
> up.
>
> More importantly, please describe what happens after "will not ask".
> "will not ask you for the password and the connection fails"?
> "will not ask you for the password and the gives an error message saying
> 'authentication failure'"?
When we need to authenticate for the destination webserver, we detect an
HTTP 401, _then_ ask for the credentials, and retry the request. I'm
curious what the error condition is for the authentication failure, and
if we can do the same here (from a brief skim of rfc2616, it looks like
it should be a 407, but I do not even have a proxy set up to try).
-Peff
next prev parent reply other threads:[~2012-03-01 21:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-01 18:21 [PATCH v2 2/3] http: try http_proxy env var when http.proxy config option is not set Nelson Benitez Leon
2012-03-01 17:45 ` Sam Vilain
2012-03-01 18:33 ` Junio C Hamano
2012-03-01 19:10 ` Junio C Hamano
2012-03-01 21:01 ` Jeff King [this message]
2012-03-01 21:38 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120301210129.GD17631@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=nelsonjesus.benitez@seap.minhap.es \
--cc=sam@vilain.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).