git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Clemens Buchacher <drizzd@aon.at>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jeff King <peff@peff.net>, git@vger.kernel.org
Subject: Re: [PATCH] http.proxy: also mention https_proxy and all_proxy
Date: Sun, 4 Mar 2012 13:46:28 +0100	[thread overview]
Message-ID: <20120304124627.GA1596@ecki> (raw)
In-Reply-To: <7v399p72a8.fsf@alter.siamese.dyndns.org>

On Sat, Mar 03, 2012 at 02:22:39PM -0800, Junio C Hamano wrote:
> 
> As to the way forward, I suspect that http.proxy was a mistake to begin
> with, considering the structure of namespace our configuration variables
> fit in.  Shouldn't they be proxy.http, proxy.https, etc.?

I actually prefer the current behavior, which is to configure only one
proxy for all protocols. I have not seen a setup where HTTP and HTTPS
are routed through different proxies before. But if this is really
needed, one has the option to use the environment variable, or
remote.<name>.proxy.

I suggest instead that we map curl's CURLOPT_PROXY to core.proxy.  That
would also fit well with the remote.<name>.proxy scheme.

  reply	other threads:[~2012-03-04 12:55 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-03 14:50 [PATCH] http.proxy: also mention https_proxy and all_proxy Clemens Buchacher
2012-03-03 17:42 ` Jeff King
2012-03-03 18:33   ` [RFH] 'man:' macro for asciidoc Jakub Narebski
2012-03-03 22:22   ` [PATCH] http.proxy: also mention https_proxy and all_proxy Junio C Hamano
2012-03-04 12:46     ` Clemens Buchacher [this message]
2012-03-04 23:07       ` Junio C Hamano
2012-03-04 16:50   ` [PATCH v2] " Clemens Buchacher
2012-03-05  5:11     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120304124627.GA1596@ecki \
    --to=drizzd@aon.at \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).