git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: Willy Tarreau <w@1wt.eu>
Cc: Greg KH <greg@kroah.com>, Ben Hutchings <ben@decadent.org.uk>,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org,
	git@vger.kernel.org, Thomas Rast <trast@student.ethz.ch>
Subject: stripping [PATCH] without losing later tags from mailed patches (Re: [ 02/12] Remove COMPAT_IA32 support)
Date: Mon, 12 Mar 2012 01:48:55 -0500	[thread overview]
Message-ID: <20120312064855.GB16820@burratino> (raw)
In-Reply-To: <20120312063027.GB8971@1wt.eu>

Hi,

(adding git list and Thomas to cc)
Willy Tarreau wrote:
> On Sun, Mar 11, 2012 at 07:49:48PM -0700, Greg KH wrote:
>> On Mon, Mar 12, 2012 at 01:07:26AM +0000, Ben Hutchings wrote:

>>> The subject/first line should include '[IA64]', as in the original
>>> commit.  It looks like this has been automatically stripped.
>>
>> Yeah, munging patches to and from quilt and git will cause that to
>> happen at times, it's quite common :(
>
> Indeed, and I've even changed my patch formats in haproxy to avoid brackets
> due to this issue. The cause is that many patches are sent with a [PATCH]
> prefix and that with Git, either you keep the subject line intact or you
> remove everything that is between brackets. There's the -b option to only
> remove remove tags looking like [PATCH], but my general experience with it
> was not satisfying (I don't remind why).

Maybe the problem was as simple as "git am" not knowing about "-b".

Two relevant patches:

  f7e5ea17 (am: learn passing -b to mailinfo, 2012-01-16)
  ee2d1cb4 (mailinfo: with -b, keep space after [foo], 2012-01-16)

are in "master" and 1.7.10-rc0 and were not part of any earlier release.

Kudos to Thomas for writing them.

Jonathan

       reply	other threads:[~2012-03-12  6:49 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20120312002046.041448832@1wt.eu>
     [not found] ` <1331514446.3022.140.camel@deadeye>
     [not found]   ` <20120312024948.GB4650@kroah.com>
     [not found]     ` <20120312063027.GB8971@1wt.eu>
2012-03-12  6:48       ` Jonathan Nieder [this message]
2012-03-12  8:58         ` stripping [PATCH] without losing later tags from mailed patches (Re: [ 02/12] Remove COMPAT_IA32 support) Willy Tarreau
2012-03-12 15:20           ` Greg KH
2012-03-12 15:24             ` Willy Tarreau
2012-03-12 16:41               ` Thomas Rast
2012-03-12 16:53                 ` Willy Tarreau
2012-03-12 16:57                 ` Jonathan Nieder
2012-03-12 18:04                   ` Junio C Hamano
2012-03-12 18:50                     ` Willy Tarreau
2012-03-12 18:54                       ` Jonathan Nieder
2012-03-12 19:17                         ` Willy Tarreau
2012-03-12 21:47                     ` Thomas Rast
2012-03-12 21:56                       ` [PATCH] git-am: error out when seeing -b/--binary Jonathan Nieder
2012-03-12 22:03                         ` Thomas Rast
2012-03-12 22:22                           ` Jonathan Nieder
2012-03-13 15:31                             ` Thomas Rast
2012-03-13 15:42                               ` Jonathan Nieder
2012-03-13 15:43                                 ` Thomas Rast
2012-03-13 17:31                               ` Junio C Hamano
2012-03-13 17:51                                 ` Jonathan Nieder
2012-03-13 18:22                                   ` Junio C Hamano
2012-03-13 18:38                                     ` [PATCH] git-am: officially deprecate -b/--binary Junio C Hamano
2012-03-12 22:12                         ` [PATCH] git-am: error out when seeing -b/--binary Junio C Hamano
2012-03-12 21:57                       ` stripping [PATCH] without losing later tags from mailed patches (Re: [ 02/12] Remove COMPAT_IA32 support) Junio C Hamano
2012-03-12 16:40             ` Junio C Hamano
2012-03-12 16:48               ` Willy Tarreau
2012-03-12 17:57                 ` Junio C Hamano
2012-03-12 18:45                   ` Willy Tarreau
2012-03-12 19:29                     ` Junio C Hamano
2012-03-12 17:12               ` Greg KH
2012-03-12 18:01                 ` Junio C Hamano
2012-03-12 19:26                   ` Greg KH
2012-03-12 19:51                     ` Junio C Hamano
2012-03-12 20:19                     ` Willy Tarreau
     [not found]                   ` <m38vj5zeo5.fsf_-_@localhost.localdomain>
2012-03-12 21:41                     ` Removing unmaintained scripts Jonathan Nieder
2012-03-13  9:23                       ` Sergio
2012-03-13  9:29                         ` Thomas Rast

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120312064855.GB16820@burratino \
    --to=jrnieder@gmail.com \
    --cc=ben@decadent.org.uk \
    --cc=git@vger.kernel.org \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=trast@student.ethz.ch \
    --cc=w@1wt.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).