From: Clemens Buchacher <drizzd@aon.at>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Marc Branchaud" <marcnarc@xiplink.com>,
"Jonathan Nieder" <jrnieder@gmail.com>,
git@vger.kernel.org, "Jeff King" <peff@peff.net>,
"David Aguilar" <davvid@gmail.com>,
"Carlos Martín Nieto" <cmn@elego.de>,
"Martin von Zweigbergk" <martin.von.zweigbergk@gmail.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: Re: [PATCH/RFC] remove #!interpreter line from shell libraries
Date: Mon, 12 Mar 2012 22:38:47 +0100 [thread overview]
Message-ID: <20120312213847.GA4958@ecki> (raw)
In-Reply-To: <7vy5r5r43s.fsf@alter.siamese.dyndns.org>
On Mon, Mar 12, 2012 at 12:50:15PM -0700, Junio C Hamano wrote:
>
> > On 12-03-09 02:58 AM, Clemens Buchacher wrote:
> >>
> >> On Thu, Mar 08, 2012 at 06:14:04AM -0600, Jonathan Nieder wrote:
> >>>
> >>> -#!/bin/sh
> >>> -# git-mergetool--lib is a library for common merge tool functions
> >>> +# git-mergetool--lib is a shell library for common merge tool functions
> >>
> >> This breaks vim's filetype detection. It can still guess the file type
> >> from the .sh extension, but we strip the extension during the build.
>
> Then that _is_ a feature to make it more obvious that the file is
> not something you should be editing, no?
If that really is an issue, then we should make it write-protected.
Syntax highlighting is primarily useful for reading.
prev parent reply other threads:[~2012-03-12 21:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-08 12:14 [PATCH/RFC] remove #!interpreter line from shell libraries Jonathan Nieder
2012-03-08 12:47 ` Jeff King
2012-03-09 7:58 ` Clemens Buchacher
2012-03-12 18:53 ` Marc Branchaud
2012-03-12 19:17 ` Jonathan Nieder
2012-03-13 19:09 ` Clemens Buchacher
2012-03-12 19:50 ` Junio C Hamano
2012-03-12 21:38 ` Clemens Buchacher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120312213847.GA4958@ecki \
--to=drizzd@aon.at \
--cc=avarab@gmail.com \
--cc=cmn@elego.de \
--cc=davvid@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=marcnarc@xiplink.com \
--cc=martin.von.zweigbergk@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).