From: Jonathan Nieder <jrnieder@gmail.com>
To: Thomas Rast <trast@inf.ethz.ch>
Cc: Junio C Hamano <gitster@pobox.com>, Willy Tarreau <w@1wt.eu>,
Greg KH <greg@kroah.com>, Ben Hutchings <ben@decadent.org.uk>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
git@vger.kernel.org
Subject: Re: [PATCH] git-am: error out when seeing -b/--binary
Date: Mon, 12 Mar 2012 16:56:07 -0500 [thread overview]
Message-ID: <20120312215607.GB11362@burratino> (raw)
In-Reply-To: <87399dpk48.fsf@thomas.inf.ethz.ch>
Thomas Rast wrote:
> Ok, but if I don't get to say anything about repurposing, can I at least
> make it an error message instead of just spewing out the "invalid
> option" help?
I don't mind either way.
[...]
> --- a/git-am.sh
> +++ b/git-am.sh
> @@ -380,7 +380,9 @@ do
> -i|--interactive)
> interactive=t ;;
> -b|--binary)
> - : ;;
> + echo >&2 "The -b/--binary option was deprecated in 1.6.0 and removed in 1.7.10."
> + die "Please adjust your scripts."
> + ;;
Hm, on second thought, if people are seeing this message, I would
prefer if they write to the mailing list so we can find out about it.
So I really would rather see this say
--binary)
: ;;
and have "-b" completely unrecognized, without any words in our
defense except for a note in the release notes mentioning the option's
removal and that it has been an unadvertised backward-compatibility
no-op since 1.6.0.
Jonathan
next prev parent reply other threads:[~2012-03-12 21:56 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20120312002046.041448832@1wt.eu>
[not found] ` <1331514446.3022.140.camel@deadeye>
[not found] ` <20120312024948.GB4650@kroah.com>
[not found] ` <20120312063027.GB8971@1wt.eu>
2012-03-12 6:48 ` stripping [PATCH] without losing later tags from mailed patches (Re: [ 02/12] Remove COMPAT_IA32 support) Jonathan Nieder
2012-03-12 8:58 ` Willy Tarreau
2012-03-12 15:20 ` Greg KH
2012-03-12 15:24 ` Willy Tarreau
2012-03-12 16:41 ` Thomas Rast
2012-03-12 16:53 ` Willy Tarreau
2012-03-12 16:57 ` Jonathan Nieder
2012-03-12 18:04 ` Junio C Hamano
2012-03-12 18:50 ` Willy Tarreau
2012-03-12 18:54 ` Jonathan Nieder
2012-03-12 19:17 ` Willy Tarreau
2012-03-12 21:47 ` Thomas Rast
2012-03-12 21:56 ` Jonathan Nieder [this message]
2012-03-12 22:03 ` [PATCH] git-am: error out when seeing -b/--binary Thomas Rast
2012-03-12 22:22 ` Jonathan Nieder
2012-03-13 15:31 ` Thomas Rast
2012-03-13 15:42 ` Jonathan Nieder
2012-03-13 15:43 ` Thomas Rast
2012-03-13 17:31 ` Junio C Hamano
2012-03-13 17:51 ` Jonathan Nieder
2012-03-13 18:22 ` Junio C Hamano
2012-03-13 18:38 ` [PATCH] git-am: officially deprecate -b/--binary Junio C Hamano
2012-03-12 22:12 ` [PATCH] git-am: error out when seeing -b/--binary Junio C Hamano
2012-03-12 21:57 ` stripping [PATCH] without losing later tags from mailed patches (Re: [ 02/12] Remove COMPAT_IA32 support) Junio C Hamano
2012-03-12 16:40 ` Junio C Hamano
2012-03-12 16:48 ` Willy Tarreau
2012-03-12 17:57 ` Junio C Hamano
2012-03-12 18:45 ` Willy Tarreau
2012-03-12 19:29 ` Junio C Hamano
2012-03-12 17:12 ` Greg KH
2012-03-12 18:01 ` Junio C Hamano
2012-03-12 19:26 ` Greg KH
2012-03-12 19:51 ` Junio C Hamano
2012-03-12 20:19 ` Willy Tarreau
[not found] ` <m38vj5zeo5.fsf_-_@localhost.localdomain>
2012-03-12 21:41 ` Removing unmaintained scripts Jonathan Nieder
2012-03-13 9:23 ` Sergio
2012-03-13 9:29 ` Thomas Rast
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120312215607.GB11362@burratino \
--to=jrnieder@gmail.com \
--cc=ben@decadent.org.uk \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=trast@inf.ethz.ch \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox